fix: reference table dropdown in add and edit query forms #19026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
pranita09
requested review from
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
Ashish8689
added
UI
|
@pranita09 can we add a tooltip around the FQN and name here, If the value exceeds the select box if hard to get the name of the entity. 
|
Jest test CoverageUI tests summary
|
...c/components/Database/TableQueries/QueryUsedByOtherTable/QueryUsedByOtherTable.component.tsx
Outdated
Show resolved
Hide resolved
aniketkatkar97
previously approved these changes
Dec 12, 2024
ShaileshParmar11
previously approved these changes
Dec 16, 2024
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
ShaileshParmar11
had a problem deploying
to
test
GitHub Actions
Failure
|
ShaileshParmar11
approved these changes
Jan 8, 2025
aniketkatkar97
approved these changes
Jan 8, 2025
ShaileshParmar11
added a commit
that referenced
this pull request
Jan 8, 2025
* fix: reference table dropdown in add and edit query forms * fix: show full value of fqn * fix: e2e test for create new query * fix: e2e test for edit query * fix: optionLabelProp value * fix: optionLabelProp value to AsyncSelect component --------- Co-authored-by: Shailesh Parmar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Before
After
Before
After
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>