Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19147 - Executable Test Suites #19221

Merged
merged 20 commits into from
Jan 7, 2025
Merged

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Jan 3, 2025

Describe your changes:

Fixes #19147

  • We are still keeping the notion of a "parent" test suite for each test case. However, instead of being the executable test suite, it's a basic test suite. This helps us maintain the same structure and overall BE logic we currently have and ensures that all test cases have a "home".
  • We are renaming executable -> basic and executableEntityReference -> basicEntityReference in the Test Suite JSON Schema
  • We are adding the necessary migrations for this rename
    • Working on the migrations, we noticed that Test Cases had a testSuites field stored in the db, with a list of all the suites referencing the test. However, this is actually being fetched at runtime when the fields are being requested here. We are cleaning up this data.
    • testSuites were also stored in the version history of tests in entity_extension. This was raising issues when updating the test case result. Cleaning those up too
  • Created new /basic endpoints to replace the /executable endpoints. We're keeping the /executable passing deprecation headers to keep things compatible, since this will be part of 1.6.2
  • Please check the breaking changes docs for further explanations on the YAML

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull pmbrull requested review from a team as code owners January 7, 2025 09:31
chirag-madlani
chirag-madlani previously approved these changes Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.57% (40678/62996) 40.74% (16285/39969) 43.89% (4927/11226)

Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

sonarqubecloud bot commented Jan 7, 2025

@pmbrull pmbrull merged commit e56f477 into open-metadata:main Jan 7, 2025
23 of 30 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Failed to cherry-pick changes to the 1.6.2 branch.
Please cherry-pick the changes manually.
You can find more details here.

pmbrull added a commit that referenced this pull request Jan 7, 2025
* backend

* format & tests

* rename backend

* migrations and ingestion

* format & tests

* format & tests

* tests

* format & tests

* tests

* updated ui side of changes

* addressing comment

* fixed failing unit test

* fix test list

* added e2e test, and fixed existing test

---------

Co-authored-by: Shailesh Parmar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executable Test Suite
4 participants