Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add missing asset specific filter options for automator filters #19268

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Minor: Add missing asset specific filter options for automator filters #19268

merged 5 commits into from
Jan 8, 2025

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Jan 7, 2025 •
edited
Loading

I worked on adding the missing asset-specific filter options for Automator filters

The tests will be covered in the https://github.com/open-metadata/openmetadata-collate/pull/1069

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Jan 7, 2025
@aniketkatkar97 aniketkatkar97 self-assigned this Jan 7, 2025
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner January 7, 2025 13:51
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 7, 2025
chirag-madlani
chirag-madlani previously approved these changes Jan 7, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.55% (40686/63029) 40.84% (16324/39973) 43.97% (4943/11242)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aniketkatkar97 aniketkatkar97 merged commit 6a28578 into main Jan 8, 2025
15 of 17 checks passed
@aniketkatkar97 aniketkatkar97 deleted the automator-filter-improvements branch January 8, 2025 01:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Changes have been cherry-picked to the 1.6.2 branch.

github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@aniketkatkar97
Minor: Add missing asset specific filter options for automator filters (
6a3f3d5 
#19268)

* Add missing filter options for glossary term, data model and stored procedure data assets.

* make the handleDeleteSelection prop optional for PipelineActionsDropdown component

* Fix the unit test

(cherry picked from commit 6a28578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani left review comments

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketkatkar97 @chirag-madlani @ShaileshParmar11