Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for DATA_TYPE_NONE to om_variable_write_scalar #14

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

terraputix
Copy link
Collaborator

@terraputix terraputix commented Feb 12, 2025

This would allow to be able to simply create groups of variables.

However, maybe it is preferable to make a separate function om_variable_write_group to have a better logical separation from the scalar methods, e.g. it might be confusing that a None-type variable cannot be read with om_variable_read_scalar.
In this case, I would suggest to also remove DATA_TYPE_NONE from the om_variable_write_scalar_size function.

@terraputix terraputix merged commit 944abf5 into main Feb 13, 2025
12 checks passed
@terraputix terraputix deleted the support-none-type-in-write-scalar-method branch February 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants