-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFA Restructure & Environment Bug Fixes #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested the MFA processing pipeline with the updated code?
Yes, the modified MFA processing pipeline ran without errors occurring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
Specify the versions of librosa and diffsptk. Standadize MFA file structure
✨ Description
/pretrained
and modify control logic in fetching and managing MFA files🚧 Related Issues
Issue [BUG]: Fix for AssertionError When Running FastSpeech2 Preprocessing (run.sh --stage 1) #118, error in training from LJSpeech dataset, arising from outdated file paths for lexicon dictionary.
Issue [BUG]: TypeError in pad_center() During FastSpeech2 Preprocessing Due to librosa Version Mismatch #119, due to package manager installing librosa 0.10+, which deprecated audioread support (See librosa 0.10 documentation)
Further testing identified additional environment issues arising from newer dependency versions causing errors. After isolation testing,
diffsptk
is confirmed to cause the error. More specifically, the dependencyvector-quantize-pytorch
. The package manager fetchesvector_quantize_pytorch
1.12.16 by default (notice the underscores instead of hyphens in the package name) instead ofvector-quantize-pytorch
. Therefore, the version should also be specified for this package to be no more than 1.12.5 for now until a change in package manager behavior.👨💻 Changes Proposed
preprocessors/ljspeech.py
to change the saving directory for MFA files from the root folder to/pretrained
to comply with file management convention for Amphion system; additionally, link lexicon directory to provided lexicon file to avoid redundant files.prepare_mfa.sh
and modifyrun.sh
for a more robust logic in fetching and managing MFA files; removing the redundant section for downloading LJSpeech lexicon.librosa
version to 0.9.1 andvector-quantize-pytorch
to 1.12.5🧑🤝🧑 Who Can Review?
@lmxue @RMSnow
🛠 TODO
Potential Consideration: A few issues seem to arise from preparing environments, one consideration could be to freeze versions for certain packages for better stability @RMSnow.
✅ Checklist