Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] Support GLIDE #1534

Merged
merged 13 commits into from
Dec 30, 2022
Merged

[Community] Support GLIDE #1534

merged 13 commits into from
Dec 30, 2022

Conversation

Taited
Copy link
Contributor

@Taited Taited commented Dec 14, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@plyfager plyfager added status/WIP work in progress normally priority/P0 highest priority labels Dec 14, 2022
@plyfager plyfager changed the title first commit of glide [Community] Support GLIDE Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 88.84% // Head: 88.87% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d7e442e) compared to base (c9ef99b).
Patch coverage: 90.06% of modified lines in pull request are covered.

❗ Current head d7e442e differs from pull request most recent head ef7bbff. Consider uploading reports for the commit ef7bbff to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1534      +/-   ##
===========================================
+ Coverage    88.84%   88.87%   +0.02%     
===========================================
  Files          394      399       +5     
  Lines        25596    26015     +419     
  Branches      3992     4044      +52     
===========================================
+ Hits         22742    23121     +379     
- Misses        1967     1991      +24     
- Partials       887      903      +16     
Flag Coverage Δ
unittests 88.87% <90.06%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/editors/ddpm/denoising_unet.py 78.61% <35.00%> (-1.97%) ⬇️
mmedit/datasets/transforms/random_degradations.py 92.25% <62.50%> (-1.77%) ⬇️
mmedit/models/editors/swinir/swinir_utils.py 89.28% <89.28%> (ø)
mmedit/models/editors/swinir/swinir_net.py 93.38% <93.38%> (ø)
mmedit/models/editors/swinir/swinir_rstb.py 93.78% <93.78%> (ø)
mmedit/models/editors/swinir/swinir_modules.py 96.61% <96.61%> (ø)
mmedit/evaluation/metrics/base_gen_metric.py 88.70% <100.00%> (+0.27%) ⬆️
mmedit/evaluation/metrics/swd.py 92.66% <100.00%> (+1.57%) ⬆️
mmedit/models/editors/__init__.py 100.00% <100.00%> (ø)
mmedit/models/editors/swinir/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plyfager plyfager self-requested a review December 19, 2022 10:35
Copy link
Collaborator

@plyfager plyfager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completing a readme and we're ready for merging.

@plyfager plyfager merged commit e7152e5 into open-mmlab:dev-1.x Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants