Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] translate documentation for loss function #1541

Merged
merged 17 commits into from
Dec 24, 2022

Conversation

willaty
Copy link
Contributor

@willaty willaty commented Dec 16, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

translate documentation for loss function

Modification

translate documentation for loss function

Who can help? @ them here!

@zengyh1900

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@willaty willaty marked this pull request as draft December 16, 2022 12:47
@zengyh1900 zengyh1900 assigned zengyh1900 and unassigned Z-Fran Dec 16, 2022
@zengyh1900 zengyh1900 self-requested a review December 16, 2022 12:50
@zengyh1900 zengyh1900 marked this pull request as ready for review December 24, 2022 08:15
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
docs/zh_cn/howto/losses.md Outdated Show resolved Hide resolved
@zengyh1900
Copy link
Collaborator

Please fix the lint by pre-commit hook.

Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zengyh1900 zengyh1900 merged commit 1ec7db3 into open-mmlab:dev-1.x Dec 24, 2022
@openmmlab-bot
Copy link
Collaborator

Dear willaty,
First of all, we want to express our gratitude for your significant PR in the MMEditing project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord:https://discord.gg/raweFPmdzG. We sincerely hope you will join us!
Best regards! @willaty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants