Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix typo of NAFNet #1557

Merged
merged 7 commits into from
Feb 23, 2023
Merged

[Fix] Fix typo of NAFNet #1557

merged 7 commits into from
Feb 23, 2023

Conversation

ydengbi
Copy link
Contributor

@ydengbi ydengbi commented Dec 26, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Z-Fran
❌ ydengbi
You have signed the CLA already but the status is still pending? Let us recheck it.

@VongolaWu VongolaWu self-requested a review December 26, 2022 07:41
@VongolaWu VongolaWu assigned VongolaWu and unassigned LeoXing1996 Dec 26, 2022
@VongolaWu VongolaWu changed the title Dev 1.x Fix NAFNet Dec 26, 2022
@VongolaWu VongolaWu changed the base branch from dev-1.x to 1.x December 26, 2022 11:05
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 88.22% // Head: 88.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9519db9) compared to base (3ea2509).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9519db9 differs from pull request most recent head ca790fb. Consider uploading reports for the commit ca790fb to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1557   +/-   ##
========================================
  Coverage    88.22%   88.23%           
========================================
  Files          401      401           
  Lines        26380    26381    +1     
  Branches      4082     4082           
========================================
+ Hits         23275    23276    +1     
  Misses        2203     2203           
  Partials       902      902           
Flag Coverage Δ
unittests 88.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/edit.py 91.76% <ø> (ø)
mmedit/models/editors/nafnet/nafnet_net.py 100.00% <ø> (ø)
mmedit/registry.py 100.00% <ø> (ø)
mmedit/apis/inferencers/base_mmedit_inferencer.py 86.66% <100.00%> (+0.12%) ⬆️
mmedit/apis/inferencers/conditional_inferencer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VongolaWu VongolaWu changed the base branch from 1.x to dev-1.x December 28, 2022 07:24
@Z-Fran Z-Fran self-assigned this Feb 23, 2023
@Z-Fran Z-Fran self-requested a review February 23, 2023 05:16
@Z-Fran Z-Fran changed the title Fix NAFNet [Fix] Fix typo of NAFNet Feb 23, 2023
@Z-Fran Z-Fran merged commit a6d75e9 into open-mmlab:dev-1.x Feb 23, 2023
@OpenMMLab-Assistant001
Copy link

Hi @ydengbi !First of all, we want to express our gratitude for your significant PR in the MMEditing project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants