Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix CI for refactor-metric-loop-and-preprocessor. #1658

Conversation

LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix CI for #1656.

Modification

Fix lint, unit test to pass CI.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 self-assigned this Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (refactor-metric-loop-and-preprocessor@be5f5f7). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 33ddc4d differs from pull request most recent head 4a3c4f6. Consider uploading reports for the commit 4a3c4f6 to get more accurate results

Additional details and impacted files
@@                           Coverage Diff                            @@
##             refactor-metric-loop-and-preprocessor    #1658   +/-   ##
========================================================================
  Coverage                                         ?   88.22%           
========================================================================
  Files                                            ?      399           
  Lines                                            ?    26254           
  Branches                                         ?     4118           
========================================================================
  Hits                                             ?    23163           
  Misses                                           ?     2224           
  Partials                                         ?      867           
Flag Coverage Δ
unittests 88.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoXing1996 LeoXing1996 merged commit bf72f22 into open-mmlab:refactor-metric-loop-and-preprocessor Feb 22, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/revise-refactor branch February 22, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant