Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 'num_images_per_prompt' argument does not work in Controlnet #1929

Closed
wants to merge 7 commits into from

Conversation

yayoyo66
Copy link

Motivation

fix the bug link

Modification

modify the function prepare_control in 'mmagic/models/editors/controlnet/controlnet.py'

BC-breaking (Optional)

I guess no

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@yayoyo66 yayoyo66 changed the title Fixing Bug : 'num_images_per_prompt' argument does not work in Controlnet [Fix] 'num_images_per_prompt' argument does not work in Controlnet Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8f2de0b) 82.59% compared to head (ec86654) 82.58%.

❗ Current head ec86654 differs from pull request most recent head eeacebf. Consider uploading reports for the commit eeacebf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   82.59%   82.58%   -0.01%     
==========================================
  Files         413      413              
  Lines       27811    27814       +3     
  Branches     4366     4368       +2     
==========================================
  Hits        22971    22971              
- Misses       3895     3897       +2     
- Partials      945      946       +1     
Flag Coverage Δ
unittests 82.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmagic/models/editors/controlnet/controlnet.py 47.38% <0.00%> (-0.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengyh1900 zengyh1900 requested a review from LeoXing1996 July 12, 2023 09:13
@LeoXing1996
Copy link
Collaborator

Hey @yayoyo66, thanks for your controbution. We provide a better and more elegant fix in PR #1936.
Therefore we close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants