Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMSIG] Add new configuration files for StyleGAN2 #2057

Merged
merged 106 commits into from
Dec 11, 2023
Merged

[MMSIG] Add new configuration files for StyleGAN2 #2057

merged 106 commits into from
Dec 11, 2023

Conversation

xiaomile
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add new configs of StyleGAN2

The output of config_validate.py:
微信截图_20231027174342

The output of demo.py:
微信图片_20231029172621

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

xiaomile and others added 30 commits June 2, 2023 15:32
demo 示例
python mmagic\demo\mmagic_inference_demo.py --model-name deblurganv2 --model-comfig ../configs/deblurganv2/deblurganv2_fpn_inception.py --model-ckpt 权重文件路径 --img 测试图片路径 --device cpu --result-out-dir ./out.png
update model-index
CI test fix and update readme.md
fix CI test and update readme.md
代码调整,参数名保持一致
doc string coverage
add some doc string
add some doc string
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef68f11) 75.70% compared to head (30a4254) 78.41%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
+ Coverage   75.70%   78.41%   +2.71%     
==========================================
  Files         441      441              
  Lines       32295    32356      +61     
  Branches     5082     5082              
==========================================
+ Hits        24449    25373     +924     
+ Misses       6775     5759    -1016     
- Partials     1071     1224     +153     
Flag Coverage Δ
unittests 78.41% <100.00%> (+2.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaomile xiaomile closed this Oct 29, 2023
@xiaomile xiaomile reopened this Oct 29, 2023
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyh1900 zengyh1900 merged commit cd183d9 into open-mmlab:main Dec 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants