Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc about codebase deployment #1051

Merged
merged 39 commits into from
Sep 24, 2022

Conversation

lvhan028
Copy link
Collaborator

@lvhan028 lvhan028 commented Sep 15, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

In OpenMMLab 2.0, codebases remove model deployment tools and request mmdeploy to provide a guideline instead.

Modification

  • mmcls.md
  • mmdet.md
  • mmseg.md
  • mmedit.md
  • mmocr.md
  • mmpose.md

Depends on
#1052

@lvhan028 lvhan028 added the WIP label Sep 15, 2022
@lvhan028 lvhan028 changed the title update doc about mmclassfication deployment update doc about codebase deployment Sep 16, 2022
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved

Before moving on to model inference chapter, let us talk more about the converted model structure which is very important to do model inference.

The converted model locates in the working directory like `mmdeploy_models/mmdet/ort` in the previous example. It includes:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It includes: -> The output directory contains four files shown as below

docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
@ZwwWayne
Copy link

Suggest using picture links rather than PNG images to reduce the size of the repo.

@lvhan028
Copy link
Collaborator Author

Suggest using picture links rather than PNG images to reduce the size of the repo.

Those images are used as input images when converting pytorch models

@lvhan028 lvhan028 removed the WIP label Sep 23, 2022
Copy link

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the part of MMEditing is ready for merging.

docs/en/04-supported-codebases/mmdet.md Outdated Show resolved Hide resolved
@lvhan028 lvhan028 merged commit 11409d7 into open-mmlab:dev-1.x Sep 24, 2022
RunningLeon pushed a commit to RunningLeon/mmdeploy that referenced this pull request Sep 29, 2022
* update doc about mmclassfication deployment

* update install mmdeploy part

* correct mmcls deployment commands

* reformat supported models

* add deployed model specification

* update doc about mmdetection deployment

* fix according to reviewer comments

* fix according to reviewer comments

* fix according to reviewer comments

* fix according to reviewer comments

* fix according to reviewer comments

* fix according to reviewer comments

* update doc about mmsegmentation deployment

* update doc about mmocr deployment

* check in cityscapes.png as an input image for converting mmsegmentation model

* update mmocr deployment

* update mmseg.md

* update mmseg.md

* update mmocr.md

* update sdk model inference for mmocr deployment

* update according to reviewer comments

* update

* update

* update mmedit

* update mmpose deployment

* check in face.png for mmedit deployment

* update

* fix according to reviewer comments

* remove duplicate doc

* update docs in english

* update codebase documents in chinese

* fix according to reviewerss comments

* update according reviewer comments

* ObjectDetection -> Object Detection

* InstanceSegmentation -> Instance Segmentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants