Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support NIQE #80

Merged
merged 20 commits into from
Mar 3, 2023
Merged

[Feature] Support NIQE #80

merged 20 commits into from
Mar 3, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Jan 16, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support NIQE metrics for low-level vision tasks.

Modification

Support NIQE metric.

Implementation in MMEditing-1.x and Performance Comparison

MMEditing PR: open-mmlab/mmagic#1608

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Z-Fran Z-Fran requested a review from ice-tong January 16, 2023 07:55
@Z-Fran Z-Fran self-assigned this Jan 16, 2023
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good! Please modify api documents && support_matrix documents accordingly.

mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/utils/image_transforms.py Outdated Show resolved Hide resolved
@Z-Fran Z-Fran requested a review from C1rN09 February 21, 2023 04:03
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update api docs

mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
tests/test_metrics/test_niqe.py Show resolved Hide resolved
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 comments:

  1. support_matrix.md should not be updated, because it will lead to conflicts. We will update it later.
  2. also add zh_cn api docs 😄

@Z-Fran Z-Fran requested a review from zhouzaida as a code owner March 2, 2023 04:26
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
mmeval/metrics/niqe.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit a05c685 into open-mmlab:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants