Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix TypeError bug #1868

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[Bug] Fix TypeError bug #1868

merged 3 commits into from
Apr 25, 2023

Conversation

frankstorming
Copy link
Contributor

Motivation

I tried to run this command to convert my rctw format dataset to the standard format.
python tools/dataset_converters/textrecog/rctw_converter.py PATH/TO/rctw --nproc 4

Modification

I traced the bug and found the out_json_name was not correct.
In 'mmocr/tools/dataset_converters/textrecog/rctw_converter.py', I found variable dst_label_file was not correct.
I replaced the string 'format' into 'json' in both line 157 and line 159 then the command work!

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the PR you submitted had changed the last characters of dict, and I helped you revert back those unnecessary changes. Thanks!

@gaotongxiao gaotongxiao merged commit e9a31dd into open-mmlab:dev-1.x Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants