-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp#158] SimCC 1d heatmap visualization #1912
[CodeCamp#158] SimCC 1d heatmap visualization #1912
Conversation
Thank you very much for your contribution. This PR will be reviewed asap. |
@@ -12,6 +12,7 @@ | |||
|
|||
from mmpose.registry import VISUALIZERS | |||
from mmpose.structures import PoseDataSample | |||
from simCCVis import SimCCVisualizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming this file to simcc_vis.py
and placing it under mmpose/visualization
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll revise it right away. Thank you for your suggestions.
Hi @jack0rich , would you mind fixing the lint and adding an example of simcc visualization result to visualization docs? |
Sure, but I'm confused about lint.Is there a problem with the copyright of simcc_vis.py? |
Hi @jack0rich, the copyright description
is needed at the top of new files |
Move to mmpose/visualization folder
Formerly SimCCVis.py
Modify the name of the import package, SimCCVis to simcc_ vis.
Add copyright
704f5dc
to
b865dee
Compare
Motivation
Visualize SimCC one-dimensional heatmap.
Modification
A new method named
_draw_instance_xy_heap
is extended inPoseLocalVisualizer
to support the visualization of heatmaps such as SimCC.BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: