Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect file size from MPI_File_write with Type_subarray #4453

Closed
edgargabriel opened this issue Nov 6, 2017 · 1 comment
Closed

Incorrect file size from MPI_File_write with Type_subarray #4453

edgargabriel opened this issue Nov 6, 2017 · 1 comment

Comments

@edgargabriel
Copy link
Member

Thank you for taking the time to submit an issue!

Background information

This is a bug reported on the mailing list by Christopher Brady, where the overall data written is less than expected when using large datatypes created with MPI_Type_create_subarray.

What version of Open MPI are you using? (e.g., v1.10.3, v2.1.0, git branch name and hash, etc.)

Open MPI 2.x and 3.0.0

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

Please describe the system on which you are running

  • Operating system/version:
  • Computer hardware:
  • Network type:

Details of the problem

Please describe, in detail, the problem that you are having, including the behavior you expect to see, the actual behavior that you are seeing, steps to reproduce the problem, etc. It is most helpful if you can attach a small program that a developer can use to reproduce your problem.

Note: If you include verbatim output (or a code block), please use a GitHub Markdown code block like below:

shell$ mpirun -np 2 ./hello_world
@edgargabriel edgargabriel self-assigned this Nov 6, 2017
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Nov 6, 2017
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Nov 7, 2017
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Nov 7, 2017
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

Signed-off-by: Edgar Gabriel <[email protected]>
bosilca pushed a commit to bosilca/ompi that referenced this issue Dec 4, 2017
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Jan 9, 2018
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

This commit is the equivalent of commit c9bb049
on master. Directly cherry-picking does not work, since the
structure of ompio has changed significantly between the 2.x and master
branches (specifically: ompio does not use common/ompio in the 2.x series yet).

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Jan 9, 2018
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

This commit is the equivalent of commit c9bb049
on master. Directly cherry-picking does not work, since the
structure of ompio has changed significantly between the 2.x and master
branches (specifically: ompio does not use common/ompio in the 2.x series yet).

Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel added a commit to edgargabriel/ompi that referenced this issue Jan 9, 2018
This is a bug fix based on a problem reported on the mailing list.
For very large read/write operations, ompio breaks the operation
down into multiple cycles. The problem was that
one of the variables required to maintain its values
across the different cycles did not do that, and because
of that the calculations of the memory offsets was wrong.

Fixes issue open-mpi#4453

This commit is the equivalent of commit c9bb049
on master. Directly cherry-picking does not work, since the
structure of ompio has changed significantly between the 2.x and master
branches (specifically: ompio does not use common/ompio in the 2.x series yet).

Signed-off-by: Edgar Gabriel <[email protected]>
@edgargabriel
Copy link
Member Author

Fix has been applied to master, v2.1.x, v3.0.x and v3.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant