Test PGI compiler - part 2 #4623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just add new dstore code - no other changes DO NOT MERGE THIS PR Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
added 4 commits
December 14, 2017 00:56
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
|
@hjelmn I'm not sure I have the attribute test for |
__extension__ attribute Signed-off-by: Ralph Castain <[email protected]>
|
Ralph, so why was adding the check for the extension attribute configury not enough? Is it because these code changes REQUIRED extension attribute, and it was easier to revert than to implement both sides? |
|
I'm not sure what you are asking - the revert is required because the function pointer code isn't acceptable to PGI. The extension configury is desirable because the code otherwise always has the attribute, even if the compiler didn't support it. |
|
Test complete - can reproduce any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add new dstore code - no other changes
DO NOT MERGE THIS PR
Signed-off-by: Ralph Castain [email protected]