Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x: osc/pt2pt: disable osc/pt2pt for THREAD_MULTIPLE scenarios #4972

Merged

Conversation

jsquyres
Copy link
Member

As a workaround for issue #2614 for the v2.0.2 release,
do not allow for selection of the OSC PT2PT when
creating an MPI RMA window. Print a hopefully helpful
message and return an not-supported error.

This PR should be reverted once a fix for #2614
is in place.

Signed-off-by: Howard Pritchard [email protected]
(cherry picked from commit d0ffd66)

The original commit message is shown above. Followup: as of this
writing (26 Mar 2018), we do not plan to fix this issue for the v2.0.x
or v2.x. Hence, the osc/pt2pt component will continue to disable
itself in THREAD_MULTIPLE scenarios for the life of all v2.x series.
It is possible (likely?) that this will be fixed in a v3.0.x release
(where x>1).

See #2614.

@jsquyres jsquyres added the bug label Mar 26, 2018
@jsquyres jsquyres added this to the v2.1.4 milestone Mar 26, 2018
@jsquyres jsquyres requested a review from hjelmn March 26, 2018 19:54
@jsquyres jsquyres changed the title osc/pt2pt: workaround for issue 2614 for v2.0.2 osc/pt2pt: disable osc/pt2pt for THREAD_MULTIPLE scenarios Mar 26, 2018
As a workaround for issue open-mpi#2614 for the v2.0.2 release,
do not allow for selection of the OSC PT2PT when
creating an MPI RMA window.  Print a hopefully helpful
message and return an not-supported error.

This PR should be reverted once a fix for open-mpi#2614
is in place.

Signed-off-by: Howard Pritchard <[email protected]>
(cherry picked from commit d0ffd66)

The original commit message is shown above.  Followup: as of this
writing (26 Mar 2018), we do not plan to fix this issue for the v2.0.x
or v2.x.  Hence, the osc/pt2pt component will continue to disable
itself in THREAD_MULTIPLE scenarios for the life of all v2.x series.
It is possible (likely?) that this will be fixed in a v3.0.x release
(where x>1).
@jsquyres jsquyres force-pushed the pr/v2.x/disable-osc-pt2p-in-thread-multiple branch from 2f753d0 to 81d4826 Compare March 26, 2018 19:59
@jsquyres jsquyres changed the title osc/pt2pt: disable osc/pt2pt for THREAD_MULTIPLE scenarios v2.x: osc/pt2pt: disable osc/pt2pt for THREAD_MULTIPLE scenarios Mar 26, 2018
@jsquyres jsquyres merged commit 58c27d5 into open-mpi:v2.x Mar 26, 2018
@jsquyres jsquyres deleted the pr/v2.x/disable-osc-pt2p-in-thread-multiple branch March 26, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants