Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent policy file overwrite on downloads #1039

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

thevilledev
Copy link
Contributor

File existence check before downloading policies. Errors out and no overwrites. Maintains data integrity by preventing accidental policy overwrites.

Added a test which verifies the behaviour.

Fixes #957

File existence check before downloading policies. Errors out
and no overwrites. Maintains data integrity by preventing
accidental policy overwrites.

Added a test which verified the behaviour.

Signed-off-by: Ville Vesilehto <[email protected]>
Copy link
Member

@boranx boranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

Thanks for fixing it and initializing the test suite for downloader

@boranx boranx merged commit 163bdd8 into open-policy-agent:master Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: conftest pull breaks policy files if a file name is conflicted
2 participants