Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update opa v1 with v0 rego compat #3798

Merged
merged 11 commits into from
Feb 6, 2025

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jan 22, 2025

What this PR does / why we need it:

quick update to test updating opa v1.0 with v0 compat

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Merge after open-policy-agent/frameworks#518

@@ -222,6 +222,7 @@ func (d *Driver) eval(ctx context.Context, compiler *ast.Compiler, target string
rego.Query(queryPath.String()),
rego.EnablePrintStatements(d.printEnabled),
rego.PrintHook(d.printHook),
rego.SetRegoVersion(ast.RegoV0),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: this will need to be updated in frameworks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.77%. Comparing base (3350319) to head (5a5019f).
Report is 249 commits behind head on master.

Files with missing lines Patch % Lines
pkg/audit/manager.go 0.00% 5 Missing ⚠️
pkg/controller/config/process/excluder.go 0.00% 2 Missing ⚠️
pkg/controller/pubsub/pubsub_config_controller.go 33.33% 2 Missing ⚠️
pkg/drivers/k8scel/driver.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (5a5019f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (5a5019f)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3798      +/-   ##
==========================================
- Coverage   54.49%   47.77%   -6.73%     
==========================================
  Files         134      235     +101     
  Lines       12329    19861    +7532     
==========================================
+ Hits         6719     9488    +2769     
- Misses       5116     9485    +4369     
- Partials      494      888     +394     
Flag Coverage Δ
unittests 47.77% <28.57%> (-6.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan marked this pull request as ready for review January 23, 2025 21:01
@sozercan sozercan requested a review from a team as a code owner January 23, 2025 21:01
@JaydipGabani
Copy link
Contributor

Thanks @sozercan I verified the library with gator and everything works as expected.

Here is the log -

docker  run -i -v /mount/d/go/src/github.com/open-policy-agent/gatekeeper-library:/gatekeeper-library gator-container verify ./... --enable-k8s-native-validation=true
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.0/suite.yaml  0.027s
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.1/suite.yaml  0.020s
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.2/suite.yaml  0.021s
ok      ./gatekeeper-library/artifacthub/library/general/allowedreposv2/1.0.0/suite.yaml        0.038s
ok      ./gatekeeper-library/artifacthub/library/general/automount-serviceaccount-token/1.0.0/suite.yaml        0.009s
ok      ./gatekeeper-library/artifacthub/library/general/automount-serviceaccount-token/1.0.1/suite.yaml        0.013s
ok      ./gatekeeper-library/artifacthub/library/general/block-endpoint-edit-default-role/1.0.0/suite.yaml      0.009s
ok      ./gatekeeper-library/artifacthub/library/general/block-loadbalancer-services/1.0.0/suite.yaml   0.008s
ok      ./gatekeeper-library/artifacthub/library/general/block-nodeport-services/1.0.0/suite.yaml       0.004s
ok      ./gatekeeper-library/artifacthub/library/general/block-wildcard-ingress/1.0.0/suite.yaml        0.015s
ok      ./gatekeeper-library/artifacthub/library/general/block-wildcard-ingress/1.0.1/suite.yaml        0.014s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.0.0/suite.yaml       0.029s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.0.1/suite.yaml       0.029s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.1.0/suite.yaml       0.060s
ok      ./gatekeeper-library/artifacthub/library/general/containerrequests/1.0.0/suite.yaml     0.029s
ok      ./gatekeeper-library/artifacthub/library/general/containerrequests/1.0.1/suite.yaml     0.030s
ok      ./gatekeeper-library/artifacthub/library/general/containerresourceratios/1.0.0/suite.yaml       0.075s
ok      ./gatekeeper-library/artifacthub/library/general/containerresourceratios/1.0.1/suite.yaml       0.072s
ok      ./gatekeeper-library/artifacthub/library/general/containerresources/1.0.0/suite.yaml    0.079s
ok      ./gatekeeper-library/artifacthub/library/general/containerresources/1.0.1/suite.yaml    0.080s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.0.0/suite.yaml     0.008s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.0.1/suite.yaml     0.009s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.1.0/suite.yaml     0.019s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedrepos/1.0.0/suite.yaml       0.020s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedtags/1.0.0/suite.yaml        0.034s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedtags/1.0.1/suite.yaml        0.031s
ok      ./gatekeeper-library/artifacthub/library/general/disallowinteractive/1.0.0/suite.yaml   0.012s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.0/suite.yaml 0.051s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.1/suite.yaml 0.061s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.2/suite.yaml 0.064s
ok      ./gatekeeper-library/artifacthub/library/general/externalip/1.0.0/suite.yaml    0.008s
ok      ./gatekeeper-library/artifacthub/library/general/horizontalpodautoscaler/1.0.0/suite.yaml       0.024s
ok      ./gatekeeper-library/artifacthub/library/general/horizontalpodautoscaler/1.0.1/suite.yaml       0.024s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.0/suite.yaml     0.023s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.1/suite.yaml     0.023s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.2/suite.yaml     0.022s
ok      ./gatekeeper-library/artifacthub/library/general/imagedigests/1.0.0/suite.yaml  0.016s
ok      ./gatekeeper-library/artifacthub/library/general/imagedigests/1.0.1/suite.yaml  0.016s
ok      ./gatekeeper-library/artifacthub/library/general/noupdateserviceaccount/1.0.0/suite.yaml        0.010s
ok      ./gatekeeper-library/artifacthub/library/general/noupdateserviceaccount/1.0.1/suite.yaml        0.010s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.0/suite.yaml   0.026s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.1/suite.yaml   0.025s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.2/suite.yaml   0.037s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.3/suite.yaml   0.040s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.4/suite.yaml   0.039s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.0/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.1/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.2/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/general/requiredannotations/1.0.0/suite.yaml   0.011s
ok      ./gatekeeper-library/artifacthub/library/general/requiredannotations/1.0.1/suite.yaml   0.011s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.0.0/suite.yaml        0.011s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.0.1/suite.yaml        0.012s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.0/suite.yaml        0.041s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.1/suite.yaml        0.040s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.2/suite.yaml        0.067s
ok      ./gatekeeper-library/artifacthub/library/general/requiredprobes/1.0.0/suite.yaml        0.016s
ok      ./gatekeeper-library/artifacthub/library/general/requiredprobes/1.0.1/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.0.0/suite.yaml  0.037s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.0.1/suite.yaml  0.037s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.0/suite.yaml  0.071s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.1/suite.yaml  0.069s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.2/suite.yaml  0.069s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.0/suite.yaml     0.014s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.1/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.2/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.3/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.4/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.0/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.1/suite.yaml 0.011s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.2/suite.yaml 0.015s
ok      ./gatekeeper-library/artifacthub/library/general/verifydeprecatedapi/1.0.0/suite.yaml   0.073s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.0.0/suite.yaml        0.016s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.0.1/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.1.0/suite.yaml        0.074s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/apparmor/1.0.0/suite.yaml  0.018s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/apparmor/1.1.0/suite.yaml  0.163s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.0/suite.yaml      0.029s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.1/suite.yaml      0.037s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.2/suite.yaml      0.035s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.1.0/suite.yaml      0.085s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.1.1/suite.yaml      0.084s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/flexvolume-drivers/1.0.0/suite.yaml        0.011s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/flexvolume-drivers/1.0.1/suite.yaml        0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.0.0/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.0/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.1/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.2/suite.yaml 0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.3/suite.yaml 0.021s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.2.0/suite.yaml 0.259s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.0/suite.yaml   0.013s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.1/suite.yaml   0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.2/suite.yaml   0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.1.0/suite.yaml   0.139s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.0/suite.yaml   0.023s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.1/suite.yaml   0.030s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.2/suite.yaml   0.028s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.1.0/suite.yaml   0.063s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.1.1/suite.yaml   0.102s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-namespaces/1.0.0/suite.yaml   0.008s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-namespaces/1.0.1/suite.yaml   0.013s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.0/suite.yaml        0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.1/suite.yaml        0.024s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.2/suite.yaml        0.022s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.0/suite.yaml        0.131s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.1/suite.yaml        0.133s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.2/suite.yaml        0.147s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.3/suite.yaml        0.193s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.4/suite.yaml        0.225s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.0.0/suite.yaml     0.016s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.0.1/suite.yaml     0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.0/suite.yaml     0.062s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.1/suite.yaml     0.074s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml     0.076s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.0/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.1/suite.yaml        0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.2/suite.yaml        0.025s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.3/suite.yaml        0.024s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.0/suite.yaml        0.066s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.1/suite.yaml        0.080s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.2/suite.yaml        0.094s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.0.0/suite.yaml 0.016s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.0.1/suite.yaml 0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.1.0/suite.yaml 0.061s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.1.1/suite.yaml 0.132s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.0.0/suite.yaml   0.058s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.0.1/suite.yaml   0.055s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.1.0/suite.yaml   0.225s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccompv2/1.0.0/suite.yaml 0.151s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.0/suite.yaml   0.023s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.1/suite.yaml   0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.2/suite.yaml   0.029s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.3/suite.yaml   0.028s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.1.0/suite.yaml   0.214s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.0/suite.yaml     0.040s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.1/suite.yaml     0.049s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.2/suite.yaml     0.050s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.0/suite.yaml   0.009s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.1/suite.yaml   0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.2/suite.yaml   0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.1.0/suite.yaml   0.054s
ok      ./gatekeeper-library/library/general/allowedrepos/suite.yaml    0.022s
ok      ./gatekeeper-library/library/general/allowedreposv2/suite.yaml  0.037s
ok      ./gatekeeper-library/library/general/automount-serviceaccount-token/suite.yaml  0.014s
ok      ./gatekeeper-library/library/general/block-endpoint-edit-default-role/suite.yaml        0.010s
ok      ./gatekeeper-library/library/general/block-loadbalancer-services/suite.yaml     0.007s
ok      ./gatekeeper-library/library/general/block-nodeport-services/suite.yaml 0.006s
ok      ./gatekeeper-library/library/general/block-wildcard-ingress/suite.yaml  0.014s
ok      ./gatekeeper-library/library/general/containerlimits/suite.yaml 0.058s
ok      ./gatekeeper-library/library/general/containerrequests/suite.yaml       0.029s
ok      ./gatekeeper-library/library/general/containerresourceratios/suite.yaml 0.076s
ok      ./gatekeeper-library/library/general/containerresources/suite.yaml      0.079s
ok      ./gatekeeper-library/library/general/disallowanonymous/suite.yaml       0.018s
ok      ./gatekeeper-library/library/general/disallowedrepos/suite.yaml 0.020s
ok      ./gatekeeper-library/library/general/disallowedtags/suite.yaml  0.033s
ok      ./gatekeeper-library/library/general/disallowinteractive/suite.yaml     0.011s
ok      ./gatekeeper-library/library/general/ephemeralstoragelimit/suite.yaml   0.062s
ok      ./gatekeeper-library/library/general/externalip/suite.yaml      0.010s
ok      ./gatekeeper-library/library/general/horizontalpodautoscaler/suite.yaml 0.024s
ok      ./gatekeeper-library/library/general/httpsonly/suite.yaml       0.022s
ok      ./gatekeeper-library/library/general/imagedigests/suite.yaml    0.016s
ok      ./gatekeeper-library/library/general/noupdateserviceaccount/suite.yaml  0.011s
ok      ./gatekeeper-library/library/general/poddisruptionbudget/suite.yaml     0.037s
ok      ./gatekeeper-library/library/general/replicalimits/suite.yaml   0.011s
ok      ./gatekeeper-library/library/general/requiredannotations/suite.yaml     0.011s
ok      ./gatekeeper-library/library/general/requiredlabels/suite.yaml  0.068s
ok      ./gatekeeper-library/library/general/requiredprobes/suite.yaml  0.021s
ok      ./gatekeeper-library/library/general/storageclass/suite.yaml    0.068s
ok      ./gatekeeper-library/library/general/uniqueingresshost/suite.yaml       0.014s
ok      ./gatekeeper-library/library/general/uniqueserviceselector/suite.yaml   0.012s
ok      ./gatekeeper-library/library/general/verifydeprecatedapi/suite.yaml     0.072s
ok      ./gatekeeper-library/library/pod-security-policy/allow-privilege-escalation/suite.yaml  0.075s
ok      ./gatekeeper-library/library/pod-security-policy/apparmor/suite.yaml    0.162s
ok      ./gatekeeper-library/library/pod-security-policy/capabilities/suite.yaml        0.083s
ok      ./gatekeeper-library/library/pod-security-policy/flexvolume-drivers/suite.yaml  0.014s
ok      ./gatekeeper-library/library/pod-security-policy/forbidden-sysctls/suite.yaml   0.263s
ok      ./gatekeeper-library/library/pod-security-policy/fsgroup/suite.yaml     0.139s
ok      ./gatekeeper-library/library/pod-security-policy/host-filesystem/suite.yaml     0.101s
ok      ./gatekeeper-library/library/pod-security-policy/host-namespaces/suite.yaml     0.013s
ok      ./gatekeeper-library/library/pod-security-policy/host-network-ports/suite.yaml  0.224s
ok      ./gatekeeper-library/library/pod-security-policy/privileged-containers/suite.yaml       0.074s
ok      ./gatekeeper-library/library/pod-security-policy/proc-mount/suite.yaml  0.097s
ok      ./gatekeeper-library/library/pod-security-policy/read-only-root-filesystem/suite.yaml   0.135s
ok      ./gatekeeper-library/library/pod-security-policy/seccomp/suite.yaml     0.229s
ok      ./gatekeeper-library/library/pod-security-policy/seccompv2/suite.yaml   0.151s
ok      ./gatekeeper-library/library/pod-security-policy/selinux/suite.yaml     0.206s
ok      ./gatekeeper-library/library/pod-security-policy/users/suite.yaml       0.051s
ok      ./gatekeeper-library/library/pod-security-policy/volumes/suite.yaml     0.051s
PASS

docker  run -i -v /mount/d/go/src/github.com/open-policy-agent/gatekeeper-library:/gatekeeper-library gator-container --version
gator version v3.19.0-beta.1 (Feature State: beta), opa/v1.0.1, frameworks/v0.0.0-20250115145356-9e57a5775c15
docker  run -i -v /mount/d/go/src/github.com/open-policy-agent/gatekeeper-library:/gatekeeper-library gator-container verify ./... --enable-k8s-native-validation=false
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.0/suite.yaml  0.027s
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.1/suite.yaml  0.021s
ok      ./gatekeeper-library/artifacthub/library/general/allowedrepos/1.0.2/suite.yaml  0.022s
ok      ./gatekeeper-library/artifacthub/library/general/allowedreposv2/1.0.0/suite.yaml        0.036s
ok      ./gatekeeper-library/artifacthub/library/general/automount-serviceaccount-token/1.0.0/suite.yaml        0.009s
ok      ./gatekeeper-library/artifacthub/library/general/automount-serviceaccount-token/1.0.1/suite.yaml        0.014s
ok      ./gatekeeper-library/artifacthub/library/general/block-endpoint-edit-default-role/1.0.0/suite.yaml      0.009s
ok      ./gatekeeper-library/artifacthub/library/general/block-loadbalancer-services/1.0.0/suite.yaml   0.007s
ok      ./gatekeeper-library/artifacthub/library/general/block-nodeport-services/1.0.0/suite.yaml       0.004s
ok      ./gatekeeper-library/artifacthub/library/general/block-wildcard-ingress/1.0.0/suite.yaml        0.014s
ok      ./gatekeeper-library/artifacthub/library/general/block-wildcard-ingress/1.0.1/suite.yaml        0.015s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.0.0/suite.yaml       0.031s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.0.1/suite.yaml       0.030s
ok      ./gatekeeper-library/artifacthub/library/general/containerlimits/1.1.0/suite.yaml       0.059s
ok      ./gatekeeper-library/artifacthub/library/general/containerrequests/1.0.0/suite.yaml     0.030s
ok      ./gatekeeper-library/artifacthub/library/general/containerrequests/1.0.1/suite.yaml     0.029s
ok      ./gatekeeper-library/artifacthub/library/general/containerresourceratios/1.0.0/suite.yaml       0.073s
ok      ./gatekeeper-library/artifacthub/library/general/containerresourceratios/1.0.1/suite.yaml       0.070s
ok      ./gatekeeper-library/artifacthub/library/general/containerresources/1.0.0/suite.yaml    0.079s
ok      ./gatekeeper-library/artifacthub/library/general/containerresources/1.0.1/suite.yaml    0.080s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.0.0/suite.yaml     0.009s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.0.1/suite.yaml     0.008s
ok      ./gatekeeper-library/artifacthub/library/general/disallowanonymous/1.1.0/suite.yaml     0.019s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedrepos/1.0.0/suite.yaml       0.019s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedtags/1.0.0/suite.yaml        0.033s
ok      ./gatekeeper-library/artifacthub/library/general/disallowedtags/1.0.1/suite.yaml        0.031s
ok      ./gatekeeper-library/artifacthub/library/general/disallowinteractive/1.0.0/suite.yaml   0.012s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.0/suite.yaml 0.049s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.1/suite.yaml 0.062s
ok      ./gatekeeper-library/artifacthub/library/general/ephemeralstoragelimit/1.0.2/suite.yaml 0.061s
ok      ./gatekeeper-library/artifacthub/library/general/externalip/1.0.0/suite.yaml    0.010s
ok      ./gatekeeper-library/artifacthub/library/general/horizontalpodautoscaler/1.0.0/suite.yaml       0.023s
ok      ./gatekeeper-library/artifacthub/library/general/horizontalpodautoscaler/1.0.1/suite.yaml       0.022s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.0/suite.yaml     0.023s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.1/suite.yaml     0.024s
ok      ./gatekeeper-library/artifacthub/library/general/httpsonly/1.0.2/suite.yaml     0.020s
ok      ./gatekeeper-library/artifacthub/library/general/imagedigests/1.0.0/suite.yaml  0.019s
ok      ./gatekeeper-library/artifacthub/library/general/imagedigests/1.0.1/suite.yaml  0.016s
ok      ./gatekeeper-library/artifacthub/library/general/noupdateserviceaccount/1.0.0/suite.yaml        0.010s
ok      ./gatekeeper-library/artifacthub/library/general/noupdateserviceaccount/1.0.1/suite.yaml        0.010s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.0/suite.yaml   0.024s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.1/suite.yaml   0.025s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.2/suite.yaml   0.039s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.3/suite.yaml   0.040s
ok      ./gatekeeper-library/artifacthub/library/general/poddisruptionbudget/1.0.4/suite.yaml   0.039s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.0/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.1/suite.yaml 0.011s
ok      ./gatekeeper-library/artifacthub/library/general/replicalimits/1.0.2/suite.yaml 0.010s
ok      ./gatekeeper-library/artifacthub/library/general/requiredannotations/1.0.0/suite.yaml   0.012s
ok      ./gatekeeper-library/artifacthub/library/general/requiredannotations/1.0.1/suite.yaml   0.011s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.0.0/suite.yaml        0.012s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.0.1/suite.yaml        0.012s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.0/suite.yaml        0.017s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.1/suite.yaml        0.016s
ok      ./gatekeeper-library/artifacthub/library/general/requiredlabels/1.1.2/suite.yaml        0.029s
ok      ./gatekeeper-library/artifacthub/library/general/requiredprobes/1.0.0/suite.yaml        0.015s
ok      ./gatekeeper-library/artifacthub/library/general/requiredprobes/1.0.1/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.0.0/suite.yaml  0.037s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.0.1/suite.yaml  0.037s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.0/suite.yaml  0.069s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.1/suite.yaml  0.070s
ok      ./gatekeeper-library/artifacthub/library/general/storageclass/1.1.2/suite.yaml  0.070s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.0/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.1/suite.yaml     0.014s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.2/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.3/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueingresshost/1.0.4/suite.yaml     0.013s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.0/suite.yaml 0.011s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.1/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/general/uniqueserviceselector/1.0.2/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/general/verifydeprecatedapi/1.0.0/suite.yaml   0.070s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.0.0/suite.yaml        0.015s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.0.1/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/allow-privilege-escalation/1.1.0/suite.yaml        0.028s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/apparmor/1.0.0/suite.yaml  0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/apparmor/1.1.0/suite.yaml  0.058s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.0/suite.yaml      0.028s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.1/suite.yaml      0.035s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.0.2/suite.yaml      0.034s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.1.0/suite.yaml      0.040s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/capabilities/1.1.1/suite.yaml      0.037s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/flexvolume-drivers/1.0.0/suite.yaml        0.010s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/flexvolume-drivers/1.0.1/suite.yaml        0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.0.0/suite.yaml 0.009s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.0/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.1/suite.yaml 0.012s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.2/suite.yaml 0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.1.3/suite.yaml 0.016s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/forbidden-sysctls/1.2.0/suite.yaml 0.097s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.0/suite.yaml   0.013s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.1/suite.yaml   0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.0.2/suite.yaml   0.018s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/fsgroup/1.1.0/suite.yaml   0.057s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.0/suite.yaml   0.022s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.1/suite.yaml   0.028s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.0.2/suite.yaml   0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.1.0/suite.yaml   0.031s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-filesystem/1.1.1/suite.yaml   0.047s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-namespaces/1.0.0/suite.yaml   0.008s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-namespaces/1.0.1/suite.yaml   0.012s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.0/suite.yaml        0.017s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.1/suite.yaml        0.023s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.0.2/suite.yaml        0.021s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.0/suite.yaml        0.051s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.1/suite.yaml        0.050s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.2/suite.yaml        0.056s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.3/suite.yaml        0.069s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/host-network-ports/1.1.4/suite.yaml        0.082s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.0.0/suite.yaml     0.015s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.0.1/suite.yaml     0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.0/suite.yaml     0.022s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.1/suite.yaml     0.029s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml     0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.0/suite.yaml        0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.1/suite.yaml        0.019s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.2/suite.yaml        0.025s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.0.3/suite.yaml        0.025s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.0/suite.yaml        0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.1/suite.yaml        0.033s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/proc-mount/1.1.2/suite.yaml        0.039s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.0.0/suite.yaml 0.015s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.0.1/suite.yaml 0.024s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.1.0/suite.yaml 0.026s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/read-only-root-filesystem/1.1.1/suite.yaml 0.055s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.0.0/suite.yaml   0.058s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.0.1/suite.yaml   0.055s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccomp/1.1.0/suite.yaml   0.092s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/seccompv2/1.0.0/suite.yaml 0.055s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.0/suite.yaml   0.020s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.1/suite.yaml   0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.2/suite.yaml   0.026s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.0.3/suite.yaml   0.027s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/selinux/1.1.0/suite.yaml   0.073s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.0/suite.yaml     0.037s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.1/suite.yaml     0.049s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/users/1.0.2/suite.yaml     0.048s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.0/suite.yaml   0.010s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.1/suite.yaml   0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.0.2/suite.yaml   0.014s
ok      ./gatekeeper-library/artifacthub/library/pod-security-policy/volumes/1.1.0/suite.yaml   0.018s
ok      ./gatekeeper-library/library/general/allowedrepos/suite.yaml    0.021s
ok      ./gatekeeper-library/library/general/allowedreposv2/suite.yaml  0.035s
ok      ./gatekeeper-library/library/general/automount-serviceaccount-token/suite.yaml  0.013s
ok      ./gatekeeper-library/library/general/block-endpoint-edit-default-role/suite.yaml        0.009s
ok      ./gatekeeper-library/library/general/block-loadbalancer-services/suite.yaml     0.007s
ok      ./gatekeeper-library/library/general/block-nodeport-services/suite.yaml 0.005s
ok      ./gatekeeper-library/library/general/block-wildcard-ingress/suite.yaml  0.015s
ok      ./gatekeeper-library/library/general/containerlimits/suite.yaml 0.060s
ok      ./gatekeeper-library/library/general/containerrequests/suite.yaml       0.028s
ok      ./gatekeeper-library/library/general/containerresourceratios/suite.yaml 0.074s
ok      ./gatekeeper-library/library/general/containerresources/suite.yaml      0.081s
ok      ./gatekeeper-library/library/general/disallowanonymous/suite.yaml       0.018s
ok      ./gatekeeper-library/library/general/disallowedrepos/suite.yaml 0.022s
ok      ./gatekeeper-library/library/general/disallowedtags/suite.yaml  0.033s
ok      ./gatekeeper-library/library/general/disallowinteractive/suite.yaml     0.012s
ok      ./gatekeeper-library/library/general/ephemeralstoragelimit/suite.yaml   0.064s
ok      ./gatekeeper-library/library/general/externalip/suite.yaml      0.009s
ok      ./gatekeeper-library/library/general/horizontalpodautoscaler/suite.yaml 0.025s
ok      ./gatekeeper-library/library/general/httpsonly/suite.yaml       0.021s
ok      ./gatekeeper-library/library/general/imagedigests/suite.yaml    0.017s
ok      ./gatekeeper-library/library/general/noupdateserviceaccount/suite.yaml  0.010s
ok      ./gatekeeper-library/library/general/poddisruptionbudget/suite.yaml     0.041s
ok      ./gatekeeper-library/library/general/replicalimits/suite.yaml   0.011s
ok      ./gatekeeper-library/library/general/requiredannotations/suite.yaml     0.010s
ok      ./gatekeeper-library/library/general/requiredlabels/suite.yaml  0.029s
ok      ./gatekeeper-library/library/general/requiredprobes/suite.yaml  0.022s
ok      ./gatekeeper-library/library/general/storageclass/suite.yaml    0.070s
ok      ./gatekeeper-library/library/general/uniqueingresshost/suite.yaml       0.013s
ok      ./gatekeeper-library/library/general/uniqueserviceselector/suite.yaml   0.012s
ok      ./gatekeeper-library/library/general/verifydeprecatedapi/suite.yaml     0.073s
ok      ./gatekeeper-library/library/pod-security-policy/allow-privilege-escalation/suite.yaml  0.029s
ok      ./gatekeeper-library/library/pod-security-policy/apparmor/suite.yaml    0.057s
ok      ./gatekeeper-library/library/pod-security-policy/capabilities/suite.yaml        0.042s
ok      ./gatekeeper-library/library/pod-security-policy/flexvolume-drivers/suite.yaml  0.015s
ok      ./gatekeeper-library/library/pod-security-policy/forbidden-sysctls/suite.yaml   0.101s
ok      ./gatekeeper-library/library/pod-security-policy/fsgroup/suite.yaml     0.059s
ok      ./gatekeeper-library/library/pod-security-policy/host-filesystem/suite.yaml     0.055s
ok      ./gatekeeper-library/library/pod-security-policy/host-namespaces/suite.yaml     0.013s
ok      ./gatekeeper-library/library/pod-security-policy/host-network-ports/suite.yaml  0.089s
ok      ./gatekeeper-library/library/pod-security-policy/privileged-containers/suite.yaml       0.027s
ok      ./gatekeeper-library/library/pod-security-policy/proc-mount/suite.yaml  0.041s
ok      ./gatekeeper-library/library/pod-security-policy/read-only-root-filesystem/suite.yaml   0.052s
ok      ./gatekeeper-library/library/pod-security-policy/seccomp/suite.yaml     0.095s
ok      ./gatekeeper-library/library/pod-security-policy/seccompv2/suite.yaml   0.058s
ok      ./gatekeeper-library/library/pod-security-policy/selinux/suite.yaml     0.076s
ok      ./gatekeeper-library/library/pod-security-policy/users/suite.yaml       0.048s
ok      ./gatekeeper-library/library/pod-security-policy/volumes/suite.yaml     0.019s
PASS

docker  run -i -v /mount/d/go/src/github.com/open-policy-agent/gatekeeper-library:/gatekeeper-library gator-container --version
gator version v3.19.0-beta.1 (Feature State: beta), opa/v1.0.1, frameworks/v0.0.0-20250115145356-9e57a5775c15

Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
@JaydipGabani JaydipGabani added this to the v3.19.0 milestone Jan 28, 2025
@@ -15,7 +15,7 @@ import (
"github.com/open-policy-agent/frameworks/constraint/pkg/types"
pSchema "github.com/open-policy-agent/gatekeeper/v3/pkg/drivers/k8scel/schema"
"github.com/open-policy-agent/gatekeeper/v3/pkg/drivers/k8scel/transform"
"github.com/open-policy-agent/opa/storage"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does using v1/storage satisfy the interface? IIRC, constraint framework change is pointing to v0 to start.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted this to be consistent with frameworks

@@ -71,7 +71,7 @@ func (img image) newMutatedImage(domain, path, tag string) image {
}

// ignoreUnset returns `new` if `new` is set, otherwise it returns `old`.
func ignoreUnset(old, new string) string {
func ignoreUnset(old, new string) string { // nolint:revive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member Author

@sozercan sozercan Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? this is due to revive linter rule redefines-builtin-id: redefinition of the built-in function new'. since this is a single occurance, i added a nolint here

Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan requested review from maxsmythe and ritazh January 30, 2025 21:07
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit f10df9c into open-policy-agent:master Feb 6, 2025
18 checks passed
@sozercan sozercan deleted the opa-v1 branch February 6, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants