Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added bundles directory creation instructions #5682

Merged
merged 2 commits into from
Feb 22, 2023
Merged

docs: added bundles directory creation instructions #5682

merged 2 commits into from
Feb 22, 2023

Conversation

lamoboos223
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit e4abf2e
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/63f5e74c64a8510008139286
😎 Deploy Preview https://deploy-preview-5682--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@charlieegan3
Copy link
Contributor

Thanks for this @lamoboos223. We do need to make a fix here as you point out to get the bundle loading working correctly. These changes look good, do you think it makes sense to add a cd .. at the end of the section to make it clear the docker-compose file is to be created in the parent directory rather than the bundles directory?

@charlieegan3 charlieegan3 changed the title added bundles directory creation instructions docs: added bundles directory creation instructions Feb 22, 2023
@lamoboos223
Copy link
Contributor Author

yes it actually makes sense. Sorry, completely slipped out of my mind.

@charlieegan3

added more instructions to align the build with the docker so it won't fail when firing up the docker

Signed-off-by: Lama <[email protected]>
@charlieegan3 charlieegan3 merged commit df1f4a2 into open-policy-agent:main Feb 22, 2023
@charlieegan3
Copy link
Contributor

Thanks for this catch @lamoboos223!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants