[docs] Address anchor linking issue #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where the old hacky way of padding an anchor (which I added) messed with the flow of linking to anchors in tables. This makes a few changes: - hides banners with display none rather than removing them using a class on the parent - makes the article content sticky - makes the hight of the article content change based on if the banner is showing or not. Signed-off-by: Charlie Egan <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks Johan! |
charlieegan3
added a commit
that referenced
this pull request
Mar 30, 2023
* [docs] Fix dashboard hight issue #5795, merged yesterday, contained a flawed assumption: that a warning banner was always displayed. This is not the case and led to the latest docs page wrapper height being incorrect. This changes the management of the messages and dashboard wrapper to be in the same place and makes a change so that the height can be correctly calculated regardless of the version. Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where the old hacky way of padding an anchor (which I added) messed with the flow of linking to anchors in tables.
This makes a few changes:
Screen.Recording.2023-03-29.at.11.13.04.mov