Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: expanding nested expressions in every domain #6832

Merged
merged 3 commits into from
Jun 26, 2024
Merged

ast: expanding nested expressions in every domain #6832

merged 3 commits into from
Jun 26, 2024

Conversation

johanfylling
Copy link
Contributor

Fixes: #6790

johanfylling
johanfylling commented Jun 26, 2024
View reviewed changes
ast/compile_test.go

p = true {
numbers.range(1, 3, __local3__)
__local2__ = __local3__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unfortunate side effect, but it's not a semantic change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless, though. And it's needed for this not to panic, so it's fine 😎

@johanfylling
Adding yaml tests
d9dd822 
Signed-off-by: Johan Fylling <[email protected]>
@johanfylling
fixing yaml test
a80d345 
Signed-off-by: Johan Fylling <[email protected]>
srenatus
srenatus approved these changes Jun 26, 2024
View reviewed changes
ast/compile_test.go

p = true {
numbers.range(1, 3, __local3__)
__local2__ = __local3__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless, though. And it's needed for this not to panic, so it's fine 😎

@johanfylling johanfylling merged commit c2cede7 into open-policy-agent:main Jun 26, 2024
28 checks passed
@johanfylling johanfylling deleted the fix/every_w_nested_exprs_in_domain branch June 26, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenatus srenatus srenatus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPA panics in nested use of every
2 participants
@johanfylling @srenatus