Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map movement #15

Merged
merged 13 commits into from
Jul 10, 2023
Merged

Add map movement #15

merged 13 commits into from
Jul 10, 2023

Conversation

FlorianK13
Copy link
Member

No description provided.

@FlorianK13 FlorianK13 requested a review from kpoeppel July 8, 2023 11:17
@FlorianK13
Copy link
Member Author

FlorianK13 commented Jul 8, 2023

I find it rather hard to understand that you search the adress and then walk along the compass. Probably non IT people will not really understand it?

@kpoeppel Could we maybe set the compass behind an advanced settings button?

@FlorianK13
Copy link
Member Author

FlorianK13 commented Jul 8, 2023

Definitely looks better now. Could we have maybe a small ✔️ button in the middle of the arrows to resubmit the simulation? Is there also the possibility to have a small circle in the middle of the map indicating the coordinates (maybe some three js object)? This circle would then be moved by the arrows?

@kpoeppel I can also help in development here if you want.

Edit: Maybe the circle in three js is a feature for later development and not the most important thing at the moment.

@FlorianK13
Copy link
Member Author

Also when I type in random letters as address (like 'aklsjdh') it does not catch the error anymore but throws a mistake in the browser: ERROR loc is null

@kpoeppel
Copy link
Member

kpoeppel commented Jul 8, 2023

Improved the movement on the map now to make it more intuitive. There are arrow buttons and the movement is immanent, the simulation is done once the start button is pushed. The perspective now also is kept, unless a new location is typed in.

@kpoeppel
Copy link
Member

kpoeppel commented Jul 8, 2023

Also when I type in random letters as address (like 'aklsjdh') it does not catch the error anymore but throws a mistake in the browser: ERROR loc is null

Should be fixed with second latest commit.

@kpoeppel
Copy link
Member

kpoeppel commented Jul 8, 2023

Definitely looks better now. Could we have maybe a small heavy_check_mark button in the middle of the arrows to resubmit the simulation? Is there also the possibility to have a small circle in the middle of the map indicating the coordinates (maybe some three js object)? This circle would then be moved by the arrows?

@kpoeppel I can also help in development here if you want.

Add now also the object showing the center. Disappearing over time for clearer view of the simulation.

@kpoeppel
Copy link
Member

kpoeppel commented Jul 8, 2023

Fixed now also #5

@FlorianK13
Copy link
Member Author

To make the UI more intuitive I would also just fix the stepsize to 10 and delete the slider from the sidebar? Super nice decaying three js pointer by the way.

@kpoeppel
Copy link
Member

kpoeppel commented Jul 9, 2023

Last commit fixed now also Issue #13 .

@kpoeppel
Copy link
Member

kpoeppel commented Jul 9, 2023

To make the UI more intuitive I would also just fix the stepsize to 10 and delete the slider from the sidebar? Super nice decaying three js pointer by the way.

I don't know actually. I think it is a good functionality, also "Anzahl an Simulationen" and "Radius Gebäude" is not that intuitive. Rather than removing it, I would recommend to add some explaining hover text?

@FlorianK13
Copy link
Member Author

To make the UI more intuitive I would also just fix the stepsize to 10 and delete the slider from the sidebar? Super nice decaying three js pointer by the way.

I don't know actually. I think it is a good functionality, also "Anzahl an Simulationen" and "Radius Gebäude" is not that intuitive. Rather than removing it, I would recommend to add some explaining hover text?

Maybe we can put all of them behind a Advanced options button within a new PR.

@FlorianK13
Copy link
Member Author

@kpoeppel Another error I found: If I type in an adress outside of Bavaria (like Hauptstraße Stuttgart) the website does not catch that error anymore and instead throws a "Can't read the data of 'the loaded zip file'. Is it in a supported JavaScript type (String, Blob, ArrayBuffer, etc) ?"

@FlorianK13
Copy link
Member Author

I think the PR is ready to merge now @kpoeppel

@kpoeppel kpoeppel merged commit aa8aa2e into main Jul 10, 2023
@kpoeppel kpoeppel mentioned this pull request Jul 10, 2023
@FlorianK13 FlorianK13 deleted the map_movement branch August 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants