Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

184 refactor meshes in scene #235

Merged
merged 11 commits into from
Aug 30, 2024
Merged

184 refactor meshes in scene #235

merged 11 commits into from
Aug 30, 2024

Conversation

FlorianK13
Copy link
Member

  • Get rid of deletedBackgroundMeshes List
  • Store relevant information about shown objects in the geometries React state
  • Have a simulationMeshes state additionally, since for simulationMeshes it is not enough to only store the geometry - the material and colors are also needed
  • By this I fixed the bug that PV systems could not be drawn on resimulated buildings

@FlorianK13 FlorianK13 linked an issue Aug 30, 2024 that may be closed by this pull request
PV systems on resimulated buildings have no annual yield #184
Closed
@FlorianK13
Delete naming of meshes #184
354844e 
Only geometries shall be named for simplicity
@FlorianK13
Delete unused naming parameter #184
60a8228
@FlorianK13
Revert some changes #184
aae8ab3 
So that simulationMeshes handles the identification of simMeshes,
not geometries
@FlorianK13
Delete logging #184
b16dcf3
@FlorianK13 FlorianK13 requested a review from khdlr August 30, 2024 06:49
@FlorianK13 FlorianK13 merged commit f22fd32 into main Aug 30, 2024
@FlorianK13 FlorianK13 deleted the 184-refactor-meshes-in-scene branch August 30, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khdlr khdlr Awaiting requested review from khdlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PV systems on resimulated buildings have no annual yield
1 participant
@FlorianK13