Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointcloud raytracing #41

Merged
merged 26 commits into from
Aug 7, 2023
Merged

Pointcloud raytracing #41

merged 26 commits into from
Aug 7, 2023

Conversation

kpoeppel
Copy link
Member

First draft for integration point cloud data. Definitely not mergable, but as a first point of discussion on how to progress.

@kpoeppel kpoeppel requested a review from MartGro July 20, 2023 19:24
@kpoeppel
Copy link
Member Author

@FlorianK13 @MartGro , what are your opinions? (regarding how exactly to integrate / UX wise etc.)
I would like to finish this soon, as I need to focus on another side-project now.
Otherwise feel free to update on your own.

@FlorianK13
Copy link
Member

FlorianK13 commented Jul 24, 2023

  1. I get this error:
    Uncaught (in promise) RuntimeError: Aborted(CompileError: wasm validation error: at offset 4: failed to match magic number)
  • This error is still there even if I download the corresponding .laz file
  1. I get this error:
    Uncaught (in promise) Error: Can't find end of central directory : is this a zip file ? If it is, see https://stuk.github.io/jszip/documentation/howto/read_zip.html
  • I solved this error by deleting line 235ff from simulation/download.js

@FlorianK13 FlorianK13 assigned FlorianK13 and kpoeppel and unassigned FlorianK13 Jul 24, 2023
@FlorianK13
Copy link
Member

FlorianK13 commented Jul 26, 2023

Still get the same error:
Uncaught (in promise) RuntimeError: Aborted(CompileError: wasm validation error: at offset 4: failed to match magic number)
It comes from the laz-perf.js package and the createLazPerf function.

In Edge the error message is: Aborted(CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 2e 2e 2f 2e @+0)

@kpoeppel
Copy link
Member Author

Running on windows? It might be that you do not get the symbolic link. And/or you have to re-run npm install to install laz-perf. The .wasm file has to be inside the public/static/ folder somewhere in the end to get it running.

@FlorianK13
Copy link
Member

I get a laz-perf.wasm in static/js folder. I also rerun npm install.

Yes It is on windows. The error persists, still the wasm validation error.

@MartGro Is it running on your laptop?

@kpoeppel kpoeppel requested review from FlorianK13 and removed request for MartGro July 27, 2023 09:21
@kpoeppel kpoeppel force-pushed the pointcloud_raytracing branch from 6cee60f to 874ad21 Compare July 27, 2023 09:46
@kpoeppel
Copy link
Member Author

kpoeppel commented Jul 28, 2023

We resolved it now. On windows one has to manually copy the symlinked file node_modules/laz-perf/lib/web/laz-perf.wasm to public/static/js.

The latest updates integrate the translations and make it possible to opt out of laser data. Also laser data is loaded now from the LVA Bavaria proxied via our website - so all of Bavaria is usable.

From my side this would now be ready to merge. Any further comments?

@FlorianK13 @MartGro ?

@FlorianK13
Copy link
Member

Restarting the simulation via the arrows results in the error: 'Uncaught (in promise) TypeError: coordinates must be finite numbers'

@kpoeppel
Copy link
Member Author

Restarting the simulation via the arrows results in the error: 'Uncaught (in promise) TypeError: coordinates must be finite numbers'

I cannot reproduce. Did you pull the latest commits? Please provide more detailed instructions on the error.

@FlorianK13
Copy link
Member

Restarting the simulation via the arrows results in the error: 'Uncaught (in promise) TypeError: coordinates must be finite numbers'

I cannot reproduce. Did you pull the latest commits? Please provide more detailed instructions on the error.

Sorry, forgot to pull the commits 🙃

@FlorianK13
Copy link
Member

Is it right / intended that the raytracing is only done with the points? At least I get this intention when I look at 'Rathaus Augsburg' and show the pointcloud. Then, at the right side of the building there is no real shadowing even though the next building is very close (The wall of the next building only has no points from the pointcloud)

@kpoeppel kpoeppel merged commit dd378fc into main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants