Using icon to display robot #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angatupyry <[email protected]>
Signed-off-by: angatupyry <[email protected]>
Signed-off-by: angatupyry <[email protected]>
Signed-off-by: angatupyry <[email protected]>
Signed-off-by: angatupyry <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 50.89% 50.77% -0.13%
==========================================
Files 281 281
Lines 7109 7128 +19
Branches 952 977 +25
==========================================
+ Hits 3618 3619 +1
- Misses 3348 3366 +18
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: angatupyry <[email protected]>
aaronchongth
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for putting this together, @Angatupyry! Unfortunately I don't see the scale reflected properly when I pull in assets from rmf_demos_dashboard_resources, it is currently scaling according to DEFAULT_ROBOT_SCALE.
I've been testing with the dashboard resources from open-rmf/rmf_demos#196, let me know if my json is malformed
aaronchongth
requested changes
Oct 30, 2023
Signed-off-by: angatupyry <[email protected]>
aaronchongth
approved these changes
Oct 30, 2023
aaronchongth
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Render image if robot icon exists Signed-off-by: angatupyry <[email protected]> * Add scale to robot resource Signed-off-by: angatupyry <[email protected]> * Using scale if exists in resource Signed-off-by: angatupyry <[email protected]> * Make waypoints transparent Signed-off-by: angatupyry <[email protected]> * Adjust text according to its length Signed-off-by: angatupyry <[email protected]> * Remove hasOwn property control Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> (cherry picked from commit db60f9c) Signed-off-by: Aaron Chong <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Self-checks
Discussion