fix broken build by vendoring pkgs #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranay Shirodkar <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
|
As of Ubuntu 24.04 the package mismatch issue of fastapi has been addressed, and with #211 they are specified as dependencies and installed from apt so this should no longer be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
This is based on https://github.com/PranayShirodkar/rmf_demos/tree/feature/add_speed_limits however the same problems exist on the main branch.
rmf_demos_fleet_adapteruses a number of python packages not available in ros humble, these packages are not declared inpackage.xmlso it will not work without manually installing those packages.There will be errors like:
Fix applied
Most of the packages are available in ubuntu repos but they are outdated, declaring them in
package.xmlwill cause an incompatible version to be installed. The fix applied is to instead vendor these packages.