-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bevy 0.11 #180
Merged
Merged
Update to Bevy 0.11 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Closed
9 tasks
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/bevy_0.11
branch
from
September 8, 2023 07:23
a4dbe0d
to
2060bdf
Compare
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/bevy_0.11
branch
from
September 8, 2023 07:25
2060bdf
to
4c1bf8e
Compare
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
mxgrey
approved these changes
Nov 10, 2023
Signed-off-by: Luca Della Vedova <[email protected]>
Found / fixed a migration issue when removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR performs basic migration to Bevy 0.11. There are a lot of cleanups, refactors and additional features we could do in this upgrade that have been left out for the sake of simplicity, for example:
SystemParam
has been removed, we can remove all the manual splitting we had to do inwidgets/mod.rs
. Done in 2060bdf<Entity>
components, such asPoint
,Edge
,MeshConstraint
, etc.WorkcellEditor
was added. Done in 26c4a36, can be reverted if necessary.Visibility
component has now a new variant for "always visible". To preserve behavior I'm not using it but it seems it might help in a few places (i.e. drawing_editor has a todo mentioning it).Other than the
Visibility
change that also introduced a lot of boilerplate, the other parts can imho be addressed in followup PRs to avoid the complexity of this exploding dramatically.Implementation description
Other than what was necessary to make the code compile, a few other changes have been made:
Label
. It was previously mainly used for fiducials, however the use was removed in favor ofAffiliation
. It was still present forMeasurements
but not really used and set toNone
by default. The reason this had to be done is that now the bevy prelude includes aLabel
and we would have had to change all our imports statements to avoid name clashes.constraint.rs
. They are not used anymore and were effectively dead code.urdf.rs
. Same as above.bevy_mod_picking
dependency. It was not really used since we do manual raycasting throughbevy_mod_raycast
and intersection checking. Removing it had barely any side effect.assign_drawing_parent_to_new_measurements
. During refactoring it pretty much became a no-op system and measurements were not saved to new projects.The rest was just what was needed to make it run, the most complex change is rewriting the app for the new schedule, that might use an extra pair of eyes.
TODO: