Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdc: reformat files & small fixes #127

Merged
merged 1 commit into from
Sep 30, 2024
Merged

hdc: reformat files & small fixes #127

merged 1 commit into from
Sep 30, 2024

Conversation

apaolillo
Copy link
Collaborator

No description provided.

@apaolillo
hdc: reformat file
a632b0f 
Signed-off-by: Antonio Paolillo <[email protected]>
@apaolillo apaolillo requested a review from jschwe September 30, 2024 17:44
@apaolillo
Copy link
Collaborator Author

@TriedAngle FYI

jschwe
jschwe approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although its a bit more than just reformatting :D.
For the future, it would also be nice if we would check the format in CI.

@apaolillo apaolillo self-assigned this Sep 30, 2024
@apaolillo apaolillo mentioned this pull request Sep 30, 2024
Open
@apaolillo
Copy link
Collaborator Author

@jschwe You're right, I'll change the title. I also would like a CI, but for now I cannot allocate time for this.

@apaolillo apaolillo changed the title hdc: reformat files hdc: reformat files & small fixes Sep 30, 2024
@apaolillo apaolillo merged commit e1772fa into main Sep 30, 2024
1 check passed
@apaolillo apaolillo deleted the format-hdc branch September 30, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwe jschwe jschwe approved these changes

Assignees

@apaolillo apaolillo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaolillo @jschwe