Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert trailing comma in old Reader #1126

Merged
merged 1 commit into from
Feb 13, 2020
Merged

revert trailing comma in old Reader #1126

merged 1 commit into from
Feb 13, 2020

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Dec 23, 2019

According to #1062 (comment) and #1098 (comment), this PR will revert the changes to the old Reader.

@dota17
Copy link
Member Author

dota17 commented Dec 23, 2019

@kimsey0 please reviewe.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 93.786% when pulling 31e79fe on dota17:revert_trailing into 7e5485a on open-source-parsers:master.

@baylesj baylesj merged commit 3beb37e into open-source-parsers:master Feb 13, 2020
@baylesj baylesj mentioned this pull request Feb 13, 2020
Merged
@dota17 dota17 deleted the revert_trailing branch February 17, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dota17 @coveralls @baylesj