-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #495
Update README.md #495
Conversation
@L-M-Sherlock @user1823 any suggestions and crtitique are welcome |
I guess you misunderstand my words: #494 (comment) I mean, we need to notify the users. But the notification should be concise. We can put a link of the new tutorial in the notification in the README, like #494 (comment). |
I thought you wanted to modify the existing tutorial. Ok, then create a new file and add a link to it to the old readme, and I'll copy the text from this PR and submit a new PR. |
You can still work on the current PR. |
The link from README to README2 doesn't work right now, but I'm sure that will be an easy fix for you. |
FSRS has been integrated into Anki. If your version of Anki is 23.10 or newer, use the built-in FSRS. Read about how to use it [here](https://github.com/open-spaced-repetition/fsrs4anki/README2.md). | ||
If your version of Anki is 2.1.66 or older, use the standalone version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction section serves as an introduction to FSRS in general. It is not specific to the standalone version. So, I think that this message should be added to the "How to Get Started?" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think that my version of the update notification is more concise: #494 (comment)
FSRS4Anki consists of two main parts: the scheduler and the optimizer. | ||
|
||
- The scheduler replaces Anki's built-in scheduler and schedules the cards according to the FSRS algorithm. | ||
- The optimizer uses machine learning to learn your memory patterns and finds parameters that best fit your review history. For details about the working of the optimizer, please read [the mechanism of optimization](https://github.com/open-spaced-repetition/fsrs4anki/wiki/The-mechanism-of-optimization). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this part should be moved back to its original place. FSRS still consists of two main parts. It is just that they have been integrated into the same section of Deck Options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is in it's original place, in "Introduction".
I have several suggestions for the README2, but I am not sure what is the best way to put them forward. |
Is it ready to merge? For above suggestion, we can improve the readme in the next PR. |
I'd say it's ready. |
So, we can merge it. I can make further edits in a subsequent PR. |
No description provided.