Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect switch case eval when server response code is 429 #123

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

srikanthccv
Copy link
Member

While working on tests for http sender I found that it doesn't respect the retry-after for too many requests response. I believe this is a bug.

@srikanthccv srikanthccv requested a review from a team August 7, 2022 13:54
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #123 (3a465c0) into main (1a47880) will increase coverage by 1.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   74.57%   75.80%   +1.23%     
==========================================
  Files          23       23              
  Lines        1766     1765       -1     
==========================================
+ Hits         1317     1338      +21     
+ Misses        335      319      -16     
+ Partials      114      108       -6     
Impacted Files Coverage Δ
client/internal/httpsender.go 70.96% <100.00%> (+0.45%) ⬆️
client/internal/receivedprocessor.go 84.28% <0.00%> (+15.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch.

client/internal/httpsender.go Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit 89eeb30 into open-telemetry:main Aug 18, 2022
@srikanthccv srikanthccv deleted the switch-case-match branch August 19, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants