Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Websocket server compression #145

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Implement Websocket server compression #145

merged 2 commits into from
Nov 8, 2022

Conversation

phanidevavarapu
Copy link
Contributor

@phanidevavarapu phanidevavarapu commented Nov 7, 2022 •
edited by tigrannajaryan
Loading

Resolves #121

@phanidevavarapu phanidevavarapu requested a review from a team November 7, 2022 22:54
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: phanidevavarapu (7f52c0c)

@phanidevavarapu phanidevavarapu force-pushed the feature/ws-server-compress branch from cf94d5e to 7f52c0c Compare November 7, 2022 23:09
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 75.05% // Head: 76.24% // Increases project coverage by +1.18% 🎉

Coverage data is based on head (7f52c0c) compared to base (3744deb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7f52c0c differs from pull request most recent head d304ed6. Consider uploading reports for the commit d304ed6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   75.05%   76.24%   +1.18%     
==========================================
  Files          23       23              
  Lines        1792     1793       +1     
==========================================
+ Hits         1345     1367      +22     
+ Misses        334      319      -15     
+ Partials      113      107       -6
Impacted Files Coverage Δ
internal/testhelpers/tcpproxy.go 73.01% <ø> (ø)
server/serverimpl.go 58.55% <100.00%> (+0.18%) ⬆️
client/internal/receivedprocessor.go 84.28% <0.00%> (+15.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tigrannajaryan
tigrannajaryan reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @phanidevavarapu
Looks mostly good to me, just one small comment.

server/serverimpl_test.go Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan changed the title Websocket server compression implementation Implement Websocket server compression Nov 8, 2022
@tigrannajaryan tigrannajaryan merged commit 93be238 into open-telemetry:main Nov 8, 2022
@tigrannajaryan
Copy link
Member

@phanidevavarapu merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement compression in WebSocket server
2 participants
@phanidevavarapu @tigrannajaryan