Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: catch error when demo server start #236

Merged
merged 2 commits into from
Jan 11, 2024

apply reviewer's suggestion

51e1974
Select commit
Loading
Failed to load commit list.
Merged

chore: catch error when demo server start #236

apply reviewer's suggestion
51e1974
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 11, 2024 in 0s

72.65% (-3.47%) compared to efddaa2

View this Pull Request on Codecov

72.65% (-3.47%) compared to efddaa2

Details

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (51e1974) 72.65%.
Report is 42 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing ⚠️
client/internal/httpsender.go 88.00% 2 Missing and 1 partial ⚠️
client/internal/mockserver.go 85.71% 2 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
client/internal/clientcommon.go 90.90% 1 Missing ⚠️
client/internal/packagessyncer.go 0.00% 1 Missing ⚠️
client/internal/receivedprocessor.go 90.90% 1 Missing ⚠️
server/serverimpl.go 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   76.11%   72.65%   -3.47%     
==========================================
  Files          24       25       +1     
  Lines        1834     2022     +188     
==========================================
+ Hits         1396     1469      +73     
- Misses        326      443     +117     
+ Partials      112      110       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov