AgentIdentification protobuf and callback #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tigrannajaryan do you think it would be worthwhile to implement this in the example agent/server? I was wondering about that but then wasn't fully sure if it wouldn't make things too complex for the sake of the examples (e.g. agent would need to persist the instance id) |
I think it is worth showing in the example. Doesn't necessarily have to persist the instance id, can just keep it in memory during the execution session. |
pmm-sumo
commented
Mar 23, 2022
|
Also needs a rebase. |
Implements OpAMP Spec change open-telemetry/opamp-spec#63
Co-authored-by: Tigran Najaryan <[email protected]>
pmm-sumo
force-pushed
the
agent-identification
branch
from
130f449 to
cc81720
Compare
tigrannajaryan
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements OpAMP Spec change open-telemetry/opamp-spec#63