Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plain HTTP Transport in OpAMPClient #64

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Implement plain HTTP Transport in OpAMPClient #64

merged 1 commit into from
Apr 19, 2022

Conversation

tigrannajaryan
Copy link
Member

  • Added httpClient implementation of OpAMP client.
  • Renamed client to wsClient to indicates it is a WebSocket client.
  • Split Receiver into wsReceiver that contains WebSocket specific code and
    receiveProcessor that contains transport-agnostic code and used by HTTP transport
    implementation too.
  • Adjusted most existing client tests to run twice: once for wsClient and once
    for httpClient.
  • Added a couple transport specific tests to httpclient_test.go and wsclient_test.go.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review April 13, 2022 23:17
@tigrannajaryan tigrannajaryan requested a review from a team April 13, 2022 23:17
andykellr
andykellr approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I like the nextMessage struct.

@tigrannajaryan
Implement plain HTTP Transport in OpAMPClient
488d04b 
- Added httpClient implementation of OpAMP client.
- Renamed client to wsClient to indicates it is a WebSocket client.
- Split Receiver into wsReceiver that contains WebSocket specific code and
  receiveProcessor that contains transport-agnostic code and used by HTTP transport
  implementation too.
- Adjusted most existing client tests to run twice: once for wsClient and once
  for httpClient.
- Added a couple transport specific tests to httpclient_test.go and wsclient_test.go.
@tigrannajaryan tigrannajaryan force-pushed the feature/plain-http-client branch from 4743d65 to 488d04b Compare April 19, 2022 19:57
@tigrannajaryan tigrannajaryan merged commit b0398a1 into open-telemetry:main Apr 19, 2022
@tigrannajaryan tigrannajaryan deleted the feature/plain-http-client branch April 19, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@andykellr andykellr andykellr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigrannajaryan @andykellr @pmm-sumo