Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify addons and agent packages #65

Conversation

tigrannajaryan
Copy link
Member

Applies spec change open-telemetry/opamp-spec#77

@tigrannajaryan tigrannajaryan requested a review from a team April 28, 2022 18:19
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits in some comments, otherwise looks good!

client/types/callbacks.go Outdated Show resolved Hide resolved
client/types/callbacks.go Outdated Show resolved Hide resolved
internal/proto/opamp.proto Show resolved Hide resolved
@tigrannajaryan tigrannajaryan force-pushed the feature/unify-addons-and-packages branch from a207ae9 to 1882ca8 Compare May 3, 2022 12:56
@tigrannajaryan tigrannajaryan force-pushed the feature/unify-addons-and-packages branch from 1882ca8 to f174e78 Compare May 3, 2022 12:59
@tigrannajaryan
Copy link
Member Author

@pmm-sumo I missed quite a few other places where I still had "addons". All should be fixed now. PTAL.

Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some inconsistency around version and hash.

internal/proto/opamp.proto Show resolved Hide resolved
internal/proto/opamp.proto Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan force-pushed the feature/unify-addons-and-packages branch from 8379a8c to dcc408c Compare May 3, 2022 13:59
@tigrannajaryan tigrannajaryan dismissed andykellr’s stale review May 3, 2022 14:00

version vs hash must be fixed now

@tigrannajaryan tigrannajaryan merged commit fe9fda4 into open-telemetry:main May 3, 2022
@tigrannajaryan tigrannajaryan deleted the feature/unify-addons-and-packages branch May 3, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants