Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent capitalization for "Agent" and "Server" #71

Conversation

tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review May 13, 2022 15:15
@tigrannajaryan tigrannajaryan requested a review from a team May 13, 2022 15:15
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #71 (f4decfe) into main (f1d46fd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files          21       21           
  Lines        1301     1301           
=======================================
  Hits         1007     1007           
  Misses        221      221           
  Partials       73       73           
Impacted Files Coverage Δ
client/internal/clientstate.go 72.34% <ø> (ø)
client/types/callbacks.go 65.00% <ø> (ø)
server/httpconnection.go 0.00% <ø> (ø)
client/httpclient.go 92.50% <100.00%> (ø)
client/internal/clientcommon.go 78.68% <100.00%> (ø)
client/internal/httpsender.go 76.19% <100.00%> (ø)
client/internal/receivedprocessor.go 84.00% <100.00%> (ø)
client/wsclient.go 83.10% <100.00%> (ø)
server/serverimpl.go 60.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d46fd...f4decfe. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 6e80433 into open-telemetry:main May 13, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/capitalization branch May 13, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants