Remove Health from Status Report message #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenTelemetry is now working on defining how the health status should be reported via metrics: open-telemetry/oteps#185 I am removing it from here so that if the metric is added we can use that. In the unlikely even the metric is not added we can think whether we really need it as a field in OpAMP.
djaglowski
approved these changes
Nov 17, 2021
pmm-sumo
approved these changes
Nov 17, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Nov 17, 2021
It was removed from the spec: open-telemetry/opamp-spec#32 This change aligns the proto with the spec.
djaglowski
pushed a commit
to open-telemetry/opamp-go
that referenced
this pull request
Nov 17, 2021
It was removed from the spec: open-telemetry/opamp-spec#32 This change aligns the proto with the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry is now working on defining how the health status should
be reported via metrics: open-telemetry/oteps#185
I am removing it from here so that if the metric is added we can use that.
In the unlikely even the metric is not added we can think whether we really
need it as a field in OpAMP.