Apply suggestions from code review

Co-authored-by: Kent Quirk <[email protected]>
open-telemetry · Mar 11, 2024 · 3701d15 · 3701d15
1 parent 93c9bb8
commit 3701d15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/exporter/loadbalancingexporter/README.md b/exporter/loadbalancingexporter/README.md
@@ -177,7 +177,7 @@ The format for the name of an SRV record is `_service._proto.name` such as `_lda
 Note that we do not define a port in the config since the port is provided by the record. The target must be either an A or AAAA record. For more information see https://www.ietf.org/rfc/rfc2782.txt
 
 > [!IMPORTANT]
-> Currently priority and weight are not supported features. Additionally, all targets should map to a single IP address.
+> Currently priority and weight are not supported features. Additionally, all targets must map to a single IP address.
 
 
 Example Config:

diff --git a/exporter/loadbalancingexporter/resolver_dnssrvnoa.go b/exporter/loadbalancingexporter/resolver_dnssrvnoa.go
@@ -133,6 +133,7 @@ func (r *dnssrvnoaResolver) periodicallyResolve() {
 			}
 			cancel()
 		case <-r.stopCh:
+			ticker.Stop()
 			return
 		}
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -133,6 +133,7 @@ func (r *dnssrvnoaResolver) periodicallyResolve() { @@
     			}
     			cancel()
     		case <-r.stopCh:
+    			ticker.Stop()
     			return
     		}
     	}
@@ Expand Down @@