nit: refactor code following PR feedback

Signed-off-by: Rayhan Hossain <[email protected]>
open-telemetry · May 5, 2021 · a4d48a5 · a4d48a5
1 parent f557e60
commit a4d48a5
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/processor/metricstransformprocessor/metrics_transform_processor.go b/processor/metricstransformprocessor/metrics_transform_processor.go
@@ -105,11 +105,8 @@ func (f internalFilterStrict) labelMatched(metric *metricspb.Metric) bool {
 			}
 
 			keyFound = true
-			for _, timeseries := range metric.Timeseries {
-				if timeseries.LabelValues[idx].Value != value {
-					return false
-				}
-				break
+			if len(metric.Timeseries) > 0 && metric.Timeseries[0].LabelValues[idx].Value != value {
+				return false
 			}
 		}
 
@@ -159,11 +156,8 @@ func (f internalFilterRegexp) labelMatched(metric *metricspb.Metric) bool {
 			}
 
 			keyFound = true
-			for _, timeseries := range metric.Timeseries {
-				if !value.MatchString(timeseries.LabelValues[idx].Value) {
-					return false
-				}
-				break
+			if len(metric.Timeseries) > 0 && !value.MatchString(metric.Timeseries[0].LabelValues[idx].Value) {
+				return false
 			}
 		}