[exporter/datadog] Add Azure, GCP and Docker hostname providers #10819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/easy-providers
branch
from
db76af2 to
58c2699
Compare
julien-lebot
approved these changes
Jun 9, 2022
exporter/datadogexporter/internal/metadata/internal/azure/provider.go
Outdated
Show resolved
Hide resolved
exporter/datadogexporter/internal/metadata/internal/azure/provider.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Julien Lebot <[email protected]>
KSerrania
approved these changes
Jun 9, 2022
mx-psi
added
the
ready to merge
codeboten
approved these changes
Jun 9, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…-telemetry#10819) * [exporter/datadog] Add 'gcp' hostname provider * [exporter/datadog] Add 'docker' hostname provider * [exporter/datadog] Add 'azure' hostname provider * Apply suggestions from code review Co-authored-by: Julien Lebot <[email protected]> Co-authored-by: Julien Lebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Azure, GCP and Docker builtin support for hostname and host metadata resolution.
This is an internal only change under the
UsePreviewHostnameLogicconstant. A future PR will expose this via a feature flag.Link to tracking Issue: #10424