[receiver/googlecloudpubsub] allow endpoint and insecure config #10845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexvanboxel
approved these changes
Jun 10, 2022
| @@ -20,6 +20,10 @@ The following configuration options are supported: | |||
| a fallback, when no `content-type` attribute is present. | |||
| * `compression` (Optional): The compression that will be used on received data from the subscription. When set it can | |||
| only be `gzip`. This will only be used as a fallback, when no `content-encoding` attribute is present. | |||
| * `endpoint` (Optional): Override the default Pubsub Endpoint, useful when connecting to the PubSub emulator instance | |||
| or switching between [global and regional service endpoints](https://cloud.google.com/pubsub/docs/reference/service_apis_overview#service_endpoints). | |||
There was a problem hiding this comment.
never used the regional endpoints, so I tried the out of curiosity. Verified the branch locally and worked (as well with a regional endpoint)
|
@djaglowski can you kick off the tests? thanks. |
alexvanboxel
suggested changes
Jun 13, 2022
|
fixed tests. @djaglowski can you kick off again? thanks. |
alexvanboxel
approved these changes
Jun 13, 2022
|
This looks good to me, but would appreciate a final review from @alexvanboxel before I merge it. |
already did and tested. Tests give a changelog error though |
|
@k7k0, please add a changelog entry. |
…y-collector-contrib into googlecloudpubsubreceiver-emulator
k7k0
changed the title
k7k0
changed the title
alexvanboxel
approved these changes
Jun 13, 2022
djaglowski
approved these changes
Jun 13, 2022
|
all green, now only need approval from allowed approvers |
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…-telemetry#10845) * googlecloudpubsub receiver: allow endpoint and insecure config * googlecloudpubsub receiver: fix tests and doc * googlecloudpubsub receiver: revert doc change * googlecloudpubsub receiver: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #10844 allowing to connect the receiver to a local PubSub emulator instance or switching between global and regional service endpoints
Link to tracking Issue: #10844
Testing: tested locally by running the emulator and configuring the receiver with
Documentation: Added config doc for both params