Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mezmoexporter] Log HTTP errors #10875

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jsumners
Copy link
Contributor

@jsumners jsumners commented Jun 9, 2022

This change logs HTTP errors for increased visibility. We intend to follow
up at a later date with more robust error handling. This change is
meant to give users some insight into misconfigurations.

@jsumners jsumners requested a review from a team June 9, 2022 19:00
@jsumners jsumners requested a review from dashpole as a code owner June 9, 2022 19:00
@jsumners jsumners force-pushed the log-on-http-error branch from 439edee to 2dfcd70 Compare June 9, 2022 19:01
exporter/mezmoexporter/factory.go Outdated Show resolved Hide resolved
exporter/mezmoexporter/factory.go Outdated Show resolved Hide resolved
@jsumners jsumners force-pushed the log-on-http-error branch 3 times, most recently from 79ab897 to 09126c0 Compare June 9, 2022 20:08
@jsumners
Copy link
Contributor Author

jsumners commented Jun 9, 2022

I'm not sure why CI is asking me to run make gotidy:

// snip leading output of `make gotidy`
go mod tidy -compat=1.17
rm -fr go.sum
go mod tidy -compat=1.17

opentelemetry-collector-contrib on  log-on-http-error took 41s 
❯ git status           
On branch log-on-http-error
Your branch is up to date with 'origin/log-on-http-error'.

nothing to commit, working tree clean

@jsumners jsumners force-pushed the log-on-http-error branch 2 times, most recently from 87c09f3 to 03eb1e3 Compare June 13, 2022 13:50
@jsumners
Copy link
Contributor Author

Can someone provide me with some guidance on this check? https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6862676992?check_suite_focus=true#step:9:1169

As noted above, I have run the suggested script and it results in no changes to commit.

@dashpole
Copy link
Contributor

dashpole commented Jun 13, 2022

I see:
go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

Did you try running make gotidy?

(sorry, didn't see)

@jsumners
Copy link
Contributor Author

Did you try running make gotidy?

#10875 (comment)

@jsumners jsumners force-pushed the log-on-http-error branch from 03eb1e3 to 1307bf3 Compare June 13, 2022 20:01
@jsumners jsumners force-pushed the log-on-http-error branch 2 times, most recently from a30803b to dcdd048 Compare June 14, 2022 14:16
@jsumners
Copy link
Contributor Author

I could really use some guidance here. My Go experience is limited, and this project is quite complicated. As far as I can tell, there is nothing to be done. When I run make gotidy on my system I do not see the same error.

@mx-psi
Copy link
Member

mx-psi commented Jun 15, 2022

I could really use some guidance here. My Go experience is limited, and this project is quite complicated. As far as I can tell, there is nothing to be done. When I run make gotidy on my system I do not see the same error.

I believe you just have to revert your changes on the top-level go.mod file

@jsumners
Copy link
Contributor Author

I believe you just have to revert your changes on the top-level go.mod file

Thank you. That seems to have done it. I suspect what is happening is my IDE, GoLand, is updating that root file.

What would I search for to find documentation on how this project is setup? If this is some sort of standard setup then maybe I can find a solution to make the IDE stop doing that.

This change logs HTTP errors for increased visibility. We intend to follow
up at a later date with more robust error handling. This change is
meant to give users some insight into misconfigurations.
@jsumners jsumners force-pushed the log-on-http-error branch from acc53e7 to 48ec275 Compare June 15, 2022 13:37
@djaglowski djaglowski dismissed bogdandrutu’s stale review June 15, 2022 14:57

Requested change was made

@djaglowski djaglowski merged commit 58d3a2c into open-telemetry:main Jun 15, 2022
@mx-psi
Copy link
Member

mx-psi commented Jun 15, 2022

What would I search for to find documentation on how this project is setup? If this is some sort of standard setup then maybe I can find a solution to make the IDE stop doing that.

I am not familiar with Goland but it may be related to our use of nested Go modules? There are some notes here about this: golang/go/issues/32394

@jsumners jsumners deleted the log-on-http-error branch June 15, 2022 15:51
@jsumners
Copy link
Contributor Author

I am not familiar with Goland but it may be related to our use of nested Go modules? There are some notes here about this: golang/go/issues/32394

Thank you. That gives me some direction on how to determine a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants