[processor/transform] Fix log accessor bugs #10903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @anuraaga |
anuraaga
approved these changes
Jun 11, 2022
bogdandrutu
reviewed
Jun 12, 2022
| @@ -299,7 +299,7 @@ func accessDroppedAttributesCount() pathGetSetter { | |||
| func accessFlags() pathGetSetter { | |||
| return pathGetSetter{ | |||
| getter: func(ctx common.TransformContext) interface{} { | |||
| return ctx.GetItem().(plog.LogRecord).Flags() | |||
| return int64(ctx.GetItem().(plog.LogRecord).Flags()) | |||
|
@open-telemetry/collector-contrib-approvers please review |
TylerHelmuth
force-pushed
the
issue-10350-logs
branch
from
54dbee6 to
f4801f7
Compare
dmitryax
approved these changes
Jun 21, 2022
Co-authored-by: Dmitrii Anoshin <[email protected]>
TylerHelmuth
added
the
ready to merge
codeboten
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some accessors for logs were not returning proper data types, breaking their usage in conditions. This PR fixes those bugs.
Link to tracking Issue:
#10350
Testing:
Updated/Added unit tests