Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Add exporter.datadog.hostname.preview feature flag #10926

Merged
merged 6 commits into from
Jun 20, 2022
Merged

[exporter/datadog] Add exporter.datadog.hostname.preview feature flag #10926

merged 6 commits into from
Jun 20, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 13, 2022 •
edited
Loading

Description:

Add exporter.datadog.hostname.preview feature flag. This feature flag

  • enables the 'preview' hostname resolution logic to use for hostname metadata, fallback hostname, and getting the hostname from OpenTelemetry semantic conventions. This hostname resolution logic is explained in more detail in the tracking issue.
  • changes the default value of host_metadata::hostname_source to config_or_system.

This will be kept as draft until the preview hostname resolution logic is fully implemented.

Link to tracking Issue: #10424

Testing: End to end test on cloud providers of the new logic:

  • Azure VM
  • Kubernetes cluster
  • ECS Fargate
  • AWS EC2
  • GCE
  • Docker
  • Bare metal
  • Set hostname in configuration

@mx-psi mx-psi mentioned this pull request Jun 14, 2022
Merged
amenasria
amenasria approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi marked this pull request as ready for review June 20, 2022 07:41
@mx-psi mx-psi requested review from a team and pmm-sumo June 20, 2022 07:41
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Jun 20, 2022
@codeboten codeboten merged commit c1eae50 into open-telemetry:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amenasria amenasria amenasria approved these changes

@gbbr gbbr gbbr approved these changes

@codeboten codeboten codeboten approved these changes

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees

@djaglowski djaglowski

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mx-psi @codeboten @gbbr @amenasria @djaglowski