Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Allow using trace_state with key-value struct. #11029

Conversation

ralphgj
Copy link
Contributor

@ralphgj ralphgj commented Jun 14, 2022

Description:
resolve #10849

Link to tracking Issue:

Testing:

Documentation:

@ralphgj ralphgj requested a review from a team June 14, 2022 07:36
@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from 9232dba to bdbd456 Compare June 14, 2022 07:36
@ralphgj ralphgj changed the title [processor/tailsampling] Allow using trace_state with key-value struct. [wip] [processor/tailsampling] Allow using trace_state with key-value struct. Jun 14, 2022
@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from bdbd456 to 6a5f663 Compare June 14, 2022 07:53
@ralphgj ralphgj changed the title [wip] [processor/tailsampling] Allow using trace_state with key-value struct. [processor/tailsampling] Allow using trace_state with key-value struct. Jun 14, 2022
@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from 6a5f663 to 5d713cc Compare June 14, 2022 08:20
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/internal/traces/traces.go Outdated Show resolved Hide resolved
processor/transformprocessor/internal/traces/traces.go Outdated Show resolved Hide resolved
processor/transformprocessor/internal/traces/traces.go Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth changed the title [processor/tailsampling] Allow using trace_state with key-value struct. [processor/transform] Allow using trace_state with key-value struct. Jun 14, 2022
@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from 5d713cc to c2e84c5 Compare June 15, 2022 03:32
@ralphgj
Copy link
Contributor Author

ralphgj commented Jun 15, 2022

@TylerHelmuth Thanks for your suggestions, I had resubmitted.

@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from c2e84c5 to 70ff44a Compare June 15, 2022 08:37
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/internal/traces/traces.go Outdated Show resolved Hide resolved
@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from 70ff44a to 158db51 Compare June 16, 2022 02:38
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TylerHelmuth
Copy link
Member

@ralphgj please take a look at the conflicts

@ralphgj ralphgj force-pushed the transformprocessor-optimize-tracestate-field branch from b5dac3e to 24f79d8 Compare June 17, 2022 15:07
@ralphgj
Copy link
Contributor Author

ralphgj commented Jun 17, 2022

@ralphgj please take a look at the conflicts

@TylerHelmuth I had resolved it, please review again. Thanks!

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Jun 17, 2022
@codeboten codeboten merged commit 63ebd10 into open-telemetry:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/transform] Optimize the use of trace_state in condition
4 participants