X-Ray Receiver validates exception fields #11431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
check-for-null-exception-fields
branch
from
a81801b to
b14f0a1
Compare
NathanielRN
force-pushed
the
check-for-null-exception-fields
branch
from
b14f0a1 to
3dbe604
Compare
srprash
approved these changes
Jun 22, 2022
Aneurysm9
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When converting span exceptions into X-Ray segments, it is possible that the span is missing a message. This PR protects against Null Pointer Exceptions by using a default
""string if either of these values are missing.Link to tracking Issue: #11064
Testing: Added a simple unit test to verify the fix.
Documentation: No documentation is needed. This is a small bug fix.
Fixes: #11064