[receiver/elasticsearch]: Add endpoint resource attribute #14774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+12
| elasticsearch.endpoint: | ||
| description: Endpoint of the queried elasticsearch node. | ||
| type: string |
There was a problem hiding this comment.
I did not decide to go for elasticsearch.node.endpoint, because we query only one node, but the results can refer to different nodes and this would be a misleading hint that both elasticsearch.node.endpoint and elasticsearch.node.name refer to the same node, while they would not.
aboguszewski-sumo
force-pushed
the
elastic-add-host
branch
from
8b3e5d7 to
3871657
Compare
djaglowski
reviewed
Oct 7, 2022
|
I checked and apparently this was not an attribute I was supposed to add, thanks for vigilance. I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a resource attribute with the endpoint of the queried node.
Link to tracking Issue: #14635
Testing:
Unit and integration tests.
Documentation:
Generated with mdatagen.